Skip to content

Fix adjustForDST to use actual DST savings #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guillerodriguez wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Open

Fix adjustForDST to use actual DST savings #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/luckycatlabs/sunrisesunset/calculator/SolarEventCalculator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,9 @@ private BigDecimal getLocalTime(BigDecimal localMeanTime, Calendar date) {
private BigDecimal adjustForDST(BigDecimal localMeanTime, Calendar date) {
BigDecimal localTime = localMeanTime;
if (timeZone.inDaylightTime(date.getTime())) {
localTime = localTime.add(BigDecimal.ONE);
long dstMillis = timeZone.getOffset(date.getTimeInMillis()) - timeZone.getRawOffset();
BigDecimal dstSavings = divideBy(BigDecimal.valueOf(dstMillis), BigDecimal.valueOf(3600000));
localTime = localTime.add(dstSavings);
}
if (localTime.doubleValue() > 24.0) {
localTime = localTime.subtract(BigDecimal.valueOf(24));
Expand Down
9 changes: 9 additions & 0 deletions src/test/java/com/luckycatlabs/sunrisesunset/calculator/SolarEventCalculatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,13 @@ public void testGetLocalTimeAsCalendarForNegative() {
assertEquals(14, localTime.get(Calendar.HOUR_OF_DAY));
assertEquals(0, localTime.get(Calendar.MINUTE));
}

@Test
public void testAdjustForDST() {
// Antarctica/Troll: standard UTC+0, DST UTC+2 (savings = +2 h).
super.setup(Calendar.APRIL, 1, 2024, "-72.0117", "2.5350", "Antarctica/Troll");
SolarEventCalculator trollCalc = new SolarEventCalculator(location, "Antarctica/Troll");
assertEquals("08:43", trollCalc.computeSunriseTime(Zenith.OFFICIAL, eventDate));
assertEquals("19:02", trollCalc.computeSunsetTime(Zenith.OFFICIAL, eventDate));
}
}