fix(activity): use DNS-valid name for not-ready event rule

[scotwells]

Problem

All 12 inventory ActivityPolicy manifests declare an eventRules entry named not_ready. That name is not a valid RFC 1123 DNS subdomain (underscores are disallowed), so the activity apiserver rejects every policy on server-side dry-run:

ActivityPolicy "inventory.miloapis.com-cluster" is invalid:
spec.eventRules[1].name: Invalid value: "not_ready": must be a valid DNS subdomain
(lowercase alphanumeric and hyphens, start/end with alphanumeric)

Observed impact (staging)

• inventory-system/inventory-milo-activity-policies Flux Kustomization stuck Ready=False (ReconciliationFailed) for ~2h.
• Parent flux-system/inventory Kustomization flapping True → Unknown on every retry.
• A stream of noisy FluxResourceNotReady alerts. The rotating error message (it fails on a different policy each reconcile — -cluster, -link, -circuit, -cable, …) made it look like many failures; it's this one root cause.

Fix

Rename the event rule not_ready → not-ready across all 12 policies.

Only the rule name changes. The match expression's event-type annotation value (inventory.<kind>.not_ready) is the string the inventory controller actually emits and is intentionally left untouched.

Validation

• grep confirms 0 remaining name: not_ready, all 12 match annotation values preserved.
• kustomize build config/components/milo-integration/ succeeds.

Once merged and the OCI artifact is published, Flux will re-apply cleanly and the FluxResourceNotReady alerts will clear.

🤖 Generated with Claude Code

[ecv]

ha