fix(activity): use DNS-valid name for not-ready event rule

config/milo/activity/policies/cable-policy.yaml

@@ -27,6 +27,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.cable.ready'"
       summary: "Inventory Cable {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.cable.not_ready'"
       summary: "Inventory Cable {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"

config/milo/activity/policies/circuit-policy.yaml

@@ -30,6 +30,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.circuit.ready'"
       summary: "Inventory Circuit {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.circuit.not_ready'"
       summary: "Inventory Circuit {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"

config/milo/activity/policies/cluster-policy.yaml

@@ -33,6 +33,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.cluster.ready'"
       summary: "Inventory Cluster {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.cluster.not_ready'"
       summary: "Inventory Cluster {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"

config/milo/activity/policies/link-policy.yaml

@@ -27,6 +27,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.link.ready'"
       summary: "Inventory Link {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.link.not_ready'"
       summary: "Inventory Link {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"

config/milo/activity/policies/networkdevice-policy.yaml

@@ -27,6 +27,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.networkdevice.ready'"
       summary: "Inventory NetworkDevice {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.networkdevice.not_ready'"
       summary: "Inventory NetworkDevice {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"

config/milo/activity/policies/node-policy.yaml

@@ -33,6 +33,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.node.ready'"
       summary: "Inventory Node {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.node.not_ready'"
       summary: "Inventory Node {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"

config/milo/activity/policies/port-policy.yaml

@@ -27,6 +27,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.port.ready'"
       summary: "Inventory Port {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.port.not_ready'"
       summary: "Inventory Port {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"

config/milo/activity/policies/provider-policy.yaml

@@ -30,6 +30,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.provider.ready'"
       summary: "Inventory Provider {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.provider.not_ready'"
       summary: "Inventory Provider {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"

config/milo/activity/policies/rack-policy.yaml

@@ -27,6 +27,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.rack.ready'"
       summary: "Inventory Rack {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.rack.not_ready'"
       summary: "Inventory Rack {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"

config/milo/activity/policies/region-policy.yaml

@@ -30,6 +30,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.region.ready'"
       summary: "Inventory Region {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.region.not_ready'"
       summary: "Inventory Region {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"

config/milo/activity/policies/site-policy.yaml

@@ -33,6 +33,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.site.ready'"
       summary: "Inventory Site {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.site.not_ready'"
       summary: "Inventory Site {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"

config/milo/activity/policies/virtualmachine-policy.yaml

@@ -27,6 +27,6 @@ spec:
     - name: ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.virtualmachine.ready'"
       summary: "Inventory VirtualMachine {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is ready"
-    - name: not_ready
+    - name: not-ready
       match: "has(event.metadata.annotations) && event.metadata.annotations['inventory.miloapis.com/event-type'] == 'inventory.virtualmachine.not_ready'"
       summary: "Inventory VirtualMachine {{ link(event.metadata.annotations['inventory.miloapis.com/display-name'], event.regarding) }} is not ready: {{ event.note }}"