generated from spawnia/php-package-template
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(samplesheet)!: Update Illumina sample sheets for NovaSeq X and cloud support #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
05a0448
https://mlllab.atlassian.net/browse/AE-4093
dhaupt88 dc14cb1
Apply php-cs-fixer changes
KingKong1213 d9958e8
Merge branch 'master' into AE-4093-update-illumina-sample-sheets
spawnia 9a1fccd
Current state
dhaupt88 d820a1c
Apply php-cs-fixer changes
KingKong1213 2fc42cf
refactor code to be usable for PHP 7.4
dhaupt88 8dea0a8
Apply php-cs-fixer changes
KingKong1213 94b5f19
refactor code to be usable for PHP 7.4
dhaupt88 2d47056
Apply php-cs-fixer changes
KingKong1213 1b1c51f
Fix class name
dhaupt88 02d74be
Add header row in CloudDataSection
dhaupt88 f5e8b7d
Apply php-cs-fixer changes
KingKong1213 0b67d61
use typed variables
dhaupt88 dbf25f4
Refactor function because of code review
dhaupt88 ca9b935
Apply php-cs-fixer changes
KingKong1213 9e614e6
Use english exception
dhaupt88 8ebcf1d
FlowcellLaneNotExistException -> FlowcellLaneDoesNotExistException
dhaupt88 14d7199
Apply php-cs-fixer changes
KingKong1213 a648ce8
Use Collection->join instead of implode
dhaupt88 3bc05e8
Apply php-cs-fixer changes
KingKong1213 180c7f4
Change namespaces in tests
dhaupt88 cc6f35c
Change namespaces in tests
dhaupt88 64b10ad
Add Cloud and local specific parameters
dhaupt88 765928e
Apply php-cs-fixer changes
KingKong1213 7a38fb8
Add Cloud and local specific parameters
dhaupt88 dd4602a
Apply php-cs-fixer changes
KingKong1213 31c1828
IndexRead2 can be null
dhaupt88 b52268b
IndexRead2 can be not be null, instead it can be 0. Change validation…
dhaupt88 38f7057
IndexRead2 can be not be null, instead it can be 0. Change validation…
dhaupt88 aa268e1
IndexRead2 can be not be null, instead it can be 0. Change validation…
dhaupt88 f29e20b
IndexRead2 can be not be null, instead it can be 0. Change validation…
dhaupt88 241bb58
Apply php-cs-fixer changes
KingKong1213 569c6b7
Use public function performAnalysisOn and Enum to ensure either cloud…
dhaupt88 1ac5e86
Apply php-cs-fixer changes
KingKong1213 252d8ca
Code Review suggestion. Prevent to manipulate object, create new obje…
dhaupt88 beac9f5
Cannot use Tag's in OverrideCycles
dhaupt88 0ee2854
barcodeMismatchesIndex2 can be empty
dhaupt88 a2912c0
Fix SpreadSheet class name casing to match PhpSpreadsheet
2b3835c
Address code review feedback
9d1aee2
Apply php-cs-fixer changes
simbig 6877cbf
Fix bugs, typos, and consistency issues
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace MLL\Utils\Flowcells; | ||
|
|
||
| class FlowcellLaneDoesNotExistException extends \Exception {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace MLL\Utils\Flowcells; | ||
|
|
||
| abstract class FlowcellType | ||
| { | ||
| abstract public function name(): string; | ||
|
|
||
| abstract public function totalLaneCount(): int; | ||
|
|
||
| /** @var array<int, int> */ | ||
| public array $lanes; | ||
|
|
||
| /** @param array<int, int>|null $lanes */ | ||
| public function __construct(?array $lanes) | ||
| { | ||
| if ($lanes === null) { | ||
| $lanes = range(1, $this->totalLaneCount()); | ||
| } | ||
| $this->validate($lanes); | ||
| $this->lanes = $lanes; | ||
| } | ||
|
|
||
| /** @param array<int, int> $specificLanes */ | ||
| public function validate(array $specificLanes): void | ||
| { | ||
| $validLanes = range(1, $this->totalLaneCount()); | ||
| $invalidLanes = array_diff($specificLanes, $validLanes); | ||
|
|
||
| if (count($invalidLanes) > 0) { | ||
| $label = count($invalidLanes) > 1 | ||
| ? 'lanes' | ||
| : 'lane'; | ||
| $invalidLanesAsString = implode(', ', $invalidLanes); | ||
|
|
||
| throw new FlowcellLaneDoesNotExistException("The Flowcell-Type: '{$this->name()}' doesn't contain {$label}: {$invalidLanesAsString}"); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace MLL\Utils\Flowcells; | ||
|
|
||
| class Miseqi100_100M extends FlowcellType | ||
| { | ||
| public function totalLaneCount(): int | ||
| { | ||
| return 1; | ||
| } | ||
|
|
||
| public function name(): string | ||
| { | ||
| return '100M'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace MLL\Utils\Flowcells; | ||
|
|
||
| class Miseqi100_25M extends FlowcellType | ||
| { | ||
| public function totalLaneCount(): int | ||
| { | ||
| return 1; | ||
| } | ||
|
|
||
| public function name(): string | ||
| { | ||
| return '25M'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace MLL\Utils\Flowcells; | ||
|
|
||
| class Miseqi100_50M extends FlowcellType | ||
| { | ||
| public function totalLaneCount(): int | ||
| { | ||
| return 1; | ||
| } | ||
|
|
||
| public function name(): string | ||
| { | ||
| return '50M'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace MLL\Utils\Flowcells; | ||
|
|
||
| class Miseqi100_5M extends FlowcellType | ||
| { | ||
| public function totalLaneCount(): int | ||
| { | ||
| return 1; | ||
| } | ||
|
|
||
| public function name(): string | ||
| { | ||
| return '5M'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace MLL\Utils\Flowcells; | ||
|
|
||
| class NovaSeqX10B extends FlowcellType | ||
| { | ||
| public function totalLaneCount(): int | ||
| { | ||
| return 8; | ||
| } | ||
|
|
||
| public function name(): string | ||
| { | ||
| return '10B'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace MLL\Utils\Flowcells; | ||
|
|
||
| class NovaSeqX1_5B extends FlowcellType | ||
| { | ||
| public function totalLaneCount(): int | ||
| { | ||
| return 2; | ||
| } | ||
|
|
||
| public function name(): string | ||
| { | ||
| return '1.5B'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace MLL\Utils\Flowcells; | ||
|
|
||
| class NovaSeqX25B extends FlowcellType | ||
| { | ||
| public function totalLaneCount(): int | ||
| { | ||
| return 8; | ||
| } | ||
|
|
||
| public function name(): string | ||
| { | ||
| return '25B'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace MLL\Utils\Flowcells; | ||
|
|
||
| class NovaSeqX5B extends FlowcellType | ||
| { | ||
| public function totalLaneCount(): int | ||
| { | ||
| return 8; | ||
| } | ||
|
|
||
| public function name(): string | ||
| { | ||
| return '5B'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,6 @@ | |
| interface Section | ||
| { | ||
| public function convertSectionToString(): string; | ||
|
|
||
| public function sectionName(): string; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 0 additions & 34 deletions
34
src/IlluminaSampleSheet/V2/BclConvert/BclConvertSection.php
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.