feat(samplesheet)!: Update Illumina sample sheets for NovaSeq X and cloud support#72
Merged
KingKong1213 merged 41 commits intomasterfrom Feb 27, 2026
Merged
Conversation
simbig
reviewed
Feb 19, 2026
Remove unused exception
… or local machine were set to perform analysis
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simbig
changed the title
- Remove redundant from() factory methods in CycleType and NucleotideType - Fix regex to reject multi-char cycle type matches like YN10 - Replace NucleotideType::from() usages with constructor calls Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simbig
changed the title
- Fix FlowcellType::validate() error message dropping lane numbers for
multi-lane case (ternary operator precedence bug)
- Fix uninitialized $analysisLocation property in trait causing TypeError
instead of MissingAnalysisLocationSelectedException
- Add input validation in OverrideCycles::fromString() for malformed
strings with fewer than 2 semicolon-separated parts
- Fix error message in OverrideCycle::fromString() ("less than 4" → "at
most 4") to match actual validation logic
- Rename FlowcellLaneDoesNotExistsException → DoesNotExistException
(grammar)
- Rename RequiresAnalysisLocationTobeSet → ToBeSet (typo)
- Replace join() with implode() and remove unnecessary Collection usage
in BclSample::toString()
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simbig
approved these changes
Feb 25, 2026
2 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
## [6.0.0](v5.25.0...v6.0.0) (2026-02-27) ### ⚠ BREAKING CHANGES * **release:** Illumina sample sheet V2 API was redesigned in the previous commit for NovaSeq X and cloud support * **samplesheet:** Update Illumina sample sheets for NovaSeq X and cloud support (#72) ### Features * **samplesheet:** Update Illumina sample sheets for NovaSeq X and cloud support ([#72](#72)) ([b27d6f8](b27d6f8)) ### Bug Fixes * **release:** use conventionalcommits preset for semantic-release ([96519b7](96519b7))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Breaking changes