Update toolchain to 2022-07-05#1340
Conversation
The updates required were related to the following changes:
- Simplify memory ordering intrinsics
- rust-lang/rust#97423
- once cell renamings
- rust-lang/rust#98165
- Rename the ConstS::val field as kind
- rust-lang/rust#97935
- Remove the source archive functionality of ArchiveWriter
- rust-lang/rust#98098
- Use valtrees as the type-system representation for constant values
- rust-lang/rust#96591
See model-checking#1339 for more details.
| ); | ||
| } | ||
| } | ||
| _ => {} |
There was a problem hiding this comment.
I believe this is a no-op. In this case, the unimplemented!() macro will be invoked at the end.
| ); | ||
| } else { | ||
| // TODO: Handle cases with other types such as tuples and larger integers. | ||
| let loc = span.map_or(Location::none(), |s| self.codegen_span(s)); |
There was a problem hiding this comment.
I think there is a codegen_span_option function that does this.
| #![feature(core_intrinsics)] | ||
| use std::intrinsics::{ | ||
| atomic_min, atomic_min_acq, atomic_min_acqrel, atomic_min_rel, atomic_min_relaxed, | ||
| atomic_min_acqrel, atomic_min_acquire, atomic_min_relaxed, atomic_min_release, |
There was a problem hiding this comment.
Looks like the new namespace may include more options for atomic intrinsics: something for @adpaco-aws to look at?
tedinski
left a comment
tedinski
left a comment
There was a problem hiding this comment.
DSN had a minor suggestion I think, then lgtm.
| (vec![], Vec::new()) | ||
| }; | ||
|
|
||
| fn new(sess: &'a Session, output: &Path) -> Self { |
There was a problem hiding this comment.
Idle comment: I copied this file (with minor changes) from cranelift. After I did so, I heard that it got updated/simplified.
It's been on my todo list to look into whether I should re-copy it.
I notice that rust-lang/rust#97485 exists though, and that might ultimately let us just delete this file. I'll track that instead?
There was a problem hiding this comment.
That would be great!
3 participants
Description of changes:
Update toolchain to 2022-07-05
The updates required were related to the following changes:
ConstS::valfield askind. rust-lang/rust#97935Resolved issues:
Resolves #1336
Call-outs:
Testing:
How is this change tested? Existing tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.