Skip to content

[codex] fix MoonBit deprecations#392

Closed
bobzhang wants to merge 1 commit into
mainfrom
codex/fix-moon-stable-deprecations
Closed

[codex] fix MoonBit deprecations#392
bobzhang wants to merge 1 commit into
mainfrom
codex/fix-moon-stable-deprecations

Conversation

@bobzhang

@bobzhang bobzhang commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the MoonBit stable-toolchain deprecations and generated-file drift currently blocking PR #391.

  • replace deprecated @buffer.new() calls with Buffer()
  • apply current moon fmt syntax for trait and impl members (with fn ..., trait fn ...)
  • migrate module manifests from moon.mod.json to moon.mod
  • keep native-only process test programs in their own nested workspace so root JS/Wasm checks do not pick them up
  • update helper executable paths for the current module-qualified native build layout
  • make file-lock tests wait for helper process lock events instead of fixed startup sleeps
  • update tests and snapshots that referenced moon.mod.json
  • update the format workflow to use moon -C src/process/test_programs fmt

Validation

  • moon clean && moon -C src/process/test_programs clean && MOONBIT_ASYNC_CHECK_FD_LEAK=1 moon test src/fs/lock_test.mbt
  • moon check --deny-warn
  • moon -C src/process/test_programs check --deny-warn
  • moon check --target js --deny-warn
  • moon check --target wasm --deny-warn
  • moon check --target wasm-gc --deny-warn
  • moon fmt --check
  • moon -C src/process/test_programs fmt --check
  • moon info
  • MOONBIT_ASYNC_CHECK_FD_LEAK=1 moon test
  • MOONBIT_ASYNC_CHECK_FD_LEAK=1 moon test --release
  • MOONBIT_ASYNC_CHECK_FD_LEAK=1 moon test --enable-coverage
  • moon test --target js
  • moon test --release --target js
  • git diff --check

@bobzhang bobzhang force-pushed the codex/fix-moon-stable-deprecations branch from 2022218 to 4ef1f53 Compare May 27, 2026 08:05
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 356

Coverage increased (+0.03%) to 79.379%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (2 of 3 lines covered, 66.67%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/websocket/deprecated.mbt 1 0 0.0%
Total (3 files) 3 2 66.67%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 4190
Covered Lines: 3326
Line Coverage: 79.38%
Coverage Strength: 80289.58 hits per line

💛 - Coveralls

@bobzhang bobzhang marked this pull request as ready for review May 27, 2026 08:13
@bobzhang bobzhang marked this pull request as draft May 27, 2026 12:56
@Guest0x0

Guest0x0 commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

close as completed

@Guest0x0 Guest0x0 closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants