MOTECH-2739 Style empty state for motech-list#37
Conversation
| @@ -0,0 +1,4 @@ | |||
| .alert { | |||
| text-align: center; | |||
| color: red; | |||
There was a problem hiding this comment.
@PJSosnowski -- let's not use red -- please use a Sass variable so we can redefine this value later -- I'd call this color $errorColor (or something)
You should define variables over here
|
Question Edits Could we also style the alert so that it looks like a bootstrap alert-warning? I feel that an empty list is more of a warning rather then a red-colored error. You should be able to |
|
@nickdotreid |
|
Extend the existing motech-list directive, but add an attribute for an empty list message That way we can hide the |
|
Can one of the admins verify this patch? |
|
test this please |
|
@PJSosnowski After your changes if a list is empty there is no alert shown. |
| controller.$inject = ['$scope']; | ||
| function controller($scope){ | ||
| var ctrl = this; | ||
| $scope.emptyListMessage = "Nothing Found"; |
There was a problem hiding this comment.
@PJSosnowski Could we define this string in messages file so it could be easy translated?
There was a problem hiding this comment.
@PJSosnowski Please remove the unused variable
|
@jredlarski I can't find proper place where I could put that message, all messages files are assigned to specific modules but motech-list is under common |
|
I just saw this thread (sorry) — I've started some documentation about adding message strings to the UI here — but you also might want to check one of the existing property files |
|
@nickdotreid Actually I've tried to use directive but it didnt work well. Now this alert is hidden/shown by css |
|
@PJSosnowski - oh that's a pretty cool.... I totally didn't think of using CSS |
|
test this please |
|
test this please |
|
@PJSosnowski Please add the empty list warning to the rest of the lists in Motech in the second PR. |
6 participants
No description provided.