Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7afec963d7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "to-valid-identifier": "^1.0.0", | ||
| "typescript": "~5.9.3", | ||
| "vite": "^7.3.1", | ||
| "vite": "^8.0.1", |
There was a problem hiding this comment.
Pin
build.target before taking the Vite 8 bump
Vite 8 raises the default browser baseline (Chrome/Edge 111, Firefox 114, Safari 16.4 in the upstream migration guide), and neither vue/vite.config.ts:27-60 nor vue/vite.demo.config.ts:22-24 overrides build.target. Because this repo publishes @nside/wefa (vue/package.json:7-19) and still validates across Chromium/Firefox/WebKit (vue/playwright.config.ts:52-70), merging the dependency bump alone silently drops support for browsers that worked with Vite 7-built artifacts, especially Safari 16.0-16.3 and Firefox 104-113. Please pin the old target explicitly or treat this as a breaking compatibility change.
Useful? React with 👍 / 👎.
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.3.1 to 8.0.1. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/create-vite@8.0.1/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 8.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7afec96 to
311e8f9
Compare
Bumps vite from 7.3.1 to 8.0.1.
Release notes
Sourced from vite's releases.
... (truncated)
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
ea68a88chore(deps): update rolldown-related dependencies (#20810)693d255release: v7.1.798a3484fix(hmr): wait forimport.meta.hot.prunecallbacks to complete before runni...9f32b1dfix(hmr): trigger prune event when import is removed from non hmr module (#20...9f2247cfix(deps): update all non-major dependencies (#20811)105abe8fix(glob): handle glob imports from folders starting with dot (#20800)4c4583cfix(build): fix ssr environmentemitAssets: truewhen `sharedConfigBuild: t...9bc9d12fix(client): use CSP nonce when rendering error overlay (#20791)54377f7release: v7.1.688af2aefix(deps): update all non-major dependencies (#20773)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)