Open
Conversation
Standardizes on --truncate-n. This preserves the --trunc-n long name previously mentioned in the SE usage. It removes the --discard-n long name only ever used internally, but never documented.
This will help keep them in sync when updating options.
No functional change, only whitespace (compare with git diff -w).
The usage docs now indicate option arguments and are easier to read. If the usage was specifically requested with --help, then it is printed to stdout instead of stderr. This is useful for the common idiom of asking for help and piping to a pager like less or more (without redirecting stderr).
Silences warnings about //-style comments and long strings. Since kseq.h uses inline functions, a feature of C99, it's not useful pretending to be C89 compat (GCC's default).
tsibley
force-pushed
the
option-sync-and-usage-cleanup
branch
from
8659760 to
beebcdb
Compare
tsibley
changed the title
This was referenced Feb 25, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@najoshi Thanks for recently fixing the option handling segfault that I had submitted PR #34 for a while back.
This is that PR rebased onto your current master since you duplicated the fix from the original first commit.
This PR:
--debugto both se and pe--truncate-n(instead of documenting--trunc-nin SE usage but only accepting--discard-n)Please let me know if you have any questions or concerns. I'm using a forked copy of sickle in various pipelines due to the changes I had to make, but I'd much rather get the fixes into your version of sickle so I can use the official one!