ci(cmd-compile): use persist-credentials: false and env indirection#697
Open
joshtrichards wants to merge 2 commits intomasterfrom
Open
ci(cmd-compile): use persist-credentials: false and env indirection#697joshtrichards wants to merge 2 commits intomasterfrom
joshtrichards wants to merge 2 commits intomasterfrom
Conversation
Defense in depth and consistency alignment with command-3rdparty's implementation:
- Switch checkout to persist-credentials: false so the PAT is not
in the credential store during npm ci / npm run build
- Add explicit git remote set-url before push steps
- Move all ${{ }} interpolations in run: blocks to env: variables
Signed-off-by: Josh <josh.t.richards@gmail.com>
8 tasks
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the
/compilecomment-command workflow template.persist-credentials: falseso the PAT is not in the credential store duringnpm ci/npm run buildgit remote set-urlbefore push steps to supply credentials at push time only${{ }}interpolation inrun:blocks withenv:indirection (defense-in-depth)Companion PR: nextcloud/server#59464