ci(update-3rdparty): fix broken push and add permission check#59464
Open
joshtrichards wants to merge 2 commits intomasterfrom
Open
ci(update-3rdparty): fix broken push and add permission check#59464joshtrichards wants to merge 2 commits intomasterfrom
joshtrichards wants to merge 2 commits intomasterfrom
Conversation
- Add missing check-actor-permission gate (require: write)
- Add git remote set-url before push to provide credentials
(persist-credentials: false meant git push had no auth)
- Move ${{ }} interpolations in run: blocks to env: variables
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
ArtificialOwl,
artonge,
icewind1991 and
leftybournes
and removed request for
a team
susnux
requested review from
miaulalala and
nickvergessen
and removed request for
ArtificialOwl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes and hardens the
/update-3rdpartycomment-command workflow.git push:persist-credentials: falsemeant there were no credentials at push time; add explicitgit remote set-urlcheck-actor-permissionwithrequire: write-- previously any commenter could trigger the workflow but since push fails anyway was a non-issue${{ }}interpolation inrun:blocks withenv:indirection (defense-in-depth)Companion PR: nextcloud/.github#697
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)