fix(file-list): updating recommended files

[alperozturk96]

Issue

We’re seeing multiple crash logs like this, but none of them clearly point to the exact root cause. Since the crash involves GridLayoutManager, it suggests that the issue is likely coming from OCFileListAdapter.java.

Looking into the adapter logic, the problem may be related to how recommended files are handled. In particular, the shouldShowHeader() logic could be causing invalid positions in the list, which might lead to this crash.

Exception java.lang.IndexOutOfBoundsException:
  at androidx.recyclerview.widget.RecyclerView$Recycler.validateViewHolderForOffsetPosition (RecyclerView.java:6590)
  at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline (RecyclerView.java:6796)
  at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition (RecyclerView.java:6757)
  at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition (RecyclerView.java:6753)
  at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next (LinearLayoutManager.java:2362)
  at androidx.recyclerview.widget.GridLayoutManager.layoutChunk (GridLayoutManager.java:584)
  at androidx.recyclerview.widget.LinearLayoutManager.fill (LinearLayoutManager.java:1622)
  at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren (LinearLayoutManager.java:687)
  at androidx.recyclerview.widget.GridLayoutManager.onLayoutChildren (GridLayoutManager.java:182)

Changes

To make this more stable, it would be safer to use notifyDataSetChanged() when updating the list, and avoid reassigning the dataset variable.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	36	36
Correctness	69	69
Dodgy code	229	229
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	34	34
Performance	42	42
Security	16	16
Total	436	436

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/24071780996/artifacts/6301777250
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.