Skip to content

fix(file-list): updating recommended files #16807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alperozturk96 merged 1 commit into from
Apr 8, 2026
Merged

fix(file-list): updating recommended files #16807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions app/src/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public class OCFileListAdapter extends RecyclerView.Adapter<RecyclerView.ViewHol
private final long footerId = UUID.randomUUID().getLeastSignificantBits();
private final long headerId = UUID.randomUUID().getLeastSignificantBits();

private ArrayList<OCFile> recommendedFiles = new ArrayList<>();
private List<OCFile> recommendedFiles = new ArrayList<>();
private RecommendedFilesAdapter recommendedFilesAdapter;
private final OCFileListAdapterHelper helper = new OCFileListAdapterHelper();
private final OverlayManager overlayManager;
Expand Down Expand Up @@ -703,14 +703,10 @@ private void setVisibilityOfMoreOption(Object holder) {
}

@SuppressLint("NotifyDataSetChanged")
public void updateRecommendedFiles(ArrayList<OCFile> recommendedFiles) {
this.recommendedFiles = recommendedFiles;

if (recommendedFiles == null || recommendedFiles.isEmpty()) {
notifyDataSetChanged();
} else {
notifyItemChanged(0);
}
public void updateRecommendedFiles(@NonNull List<OCFile> value) {
recommendedFiles.clear();
recommendedFiles.addAll(value);
notifyDataSetChanged();
}

private void applyChipVisuals(Chip chip, Tag tag) {
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/owncloud/android/ui/adapter/RecommendedFilesAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import com.owncloud.android.datamodel.OCFile

class RecommendedFilesAdapter(
private val fileListAdapter: OCFileListAdapter,
private val recommendations: ArrayList<OCFile>
private val recommendations: List<OCFile>
) : RecyclerView.Adapter<OCFileListRecommendedItemViewHolder>() {

fun getItemPosition(file: OCFile): Int = recommendations.indexOf(file)
Expand Down
Loading