fix(discovery): check quota before upload (during discovery)#9777
Open
fix(discovery): check quota before upload (during discovery)#9777
Conversation
solracsf
force-pushed
the
checkQuotaBeforeUpload
branch
from
114c6ee to
1f866cb
Compare
solracsf
changed the title
solracsf
force-pushed
the
checkQuotaBeforeUpload
branch
3 times, most recently
from
091d2a9 to
399b158
Compare
solracsf
requested review from
Aiiaiiio,
camilasan,
i2h3,
mgallien and
nilsding
as code owners
Member
Author
|
|
Collaborator
sorry for the mess |
mgallien
force-pushed
the
checkQuotaBeforeUpload
branch
from
399b158 to
e425898
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
checkQuotaBeforeUpload
branch
from
e425898 to
dcb2b54
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9777.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4580 (more an enhancement of actual behavior)
Related to nextcloud/server#51977
Related to nextcloud/server#59398
Quota is now checked during discovery, before any data is transmitted. If a file exceeds available quota it receives a
DetailErrorimmediately, with no retry scheduled. A_quotaBytesReservedcounter prevents multiple files from being approved when their combined size exceeds quota.The propagator's pre-upload guard is also improved: it now walks the folder hierarchy to find the nearest quota entry, and the propagator is seeded with PROPFIND quota data at the start of each cycle. Combined with nextcloud/server#59398 and nextcloud/groupfolders#4539 this makes this behavior almost full proof.
4 new tests cover: single file blocked, unknown quota allowed, chunked upload blocked, and two files exceeding combined quota.