Open
Conversation
Member
Any progress? Can you update the PR? |
Member
Author
|
no progress yet. I'll to fix it this eventing |
Leptopoda
force-pushed
the
chore/remove_cookie_store_package
branch
from
35a9ea1 to
baa3caf
Compare
Member
Author
|
I've used a global override for now because tag patterns require dart 3.9 which is still far away for us :( |
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Leptopoda
force-pushed
the
chore/remove_cookie_store_package
branch
from
baa3caf to
131388d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
The patch for the downgrade checks needs to be adjusted. |
Member
|
Why is the override necessary if the dependency is specified the same way in each package? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to: #3194 this removes the cookie_store and related packages from the neon codebase.
The new home is: https://github.com/foldland/cookie_store
This is still a WIP as dependency resolution will not work yet.
package:cookie_storeimportspackage:cookie_store_conformance_testfrom a local path causing dart to hick up.I'll create tags and use the tag prefix versioning to allow a better dependency resolution.