Skip to content

chore: Remove nextcloud package#3194

Draft
provokateurin wants to merge 1 commit intomainfrom
chore/remove-nextcloud-package
Draft

chore: Remove nextcloud package#3194
provokateurin wants to merge 1 commit intomainfrom
chore/remove-nextcloud-package

Conversation

@provokateurin
Copy link
Copy Markdown
Member

@provokateurin provokateurin requested a review from Leptopoda March 27, 2026 21:02
@provokateurin provokateurin force-pushed the chore/remove-nextcloud-package branch 2 times, most recently from 8f06a17 to b43fddf Compare March 27, 2026 21:51
@provokateurin provokateurin marked this pull request as draft March 27, 2026 21:51
@provokateurin
Copy link
Copy Markdown
Member Author

Some of the contributing guidelines need to be removed here and added to the other repo.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Leptopoda
Copy link
Copy Markdown
Member

please also make a release in the new repo so we can import the package through a tag.
Similar to #3195 the nextcloud package should import its sub packages through the created tag with an override to the local path.

This would allow us to also import the testing libraries in here (even though this is not something we like to do).
See: https://github.com/dart-lang/http/blob/ba5f36800879af15f0531a0c5723e9baef7a0a57/pkgs/http_client_conformance_tests/pubspec.yaml#L14-L20

@provokateurin
Copy link
Copy Markdown
Member Author

I don't really see a benefit, but if you want to change it we can do it later. For now this isn't important.

@Leptopoda
Copy link
Copy Markdown
Member

Then we should at least create an issue.
Let me know when I should do the final review (i.e. you changed the last remaining stuff like the contributing guidelines)

@provokateurin provokateurin force-pushed the chore/remove-nextcloud-package branch from b43fddf to 670eade Compare April 4, 2026 17:17
@provokateurin
Copy link
Copy Markdown
Member Author

@provokateurin provokateurin marked this pull request as ready for review April 4, 2026 17:17
@provokateurin provokateurin force-pushed the chore/remove-nextcloud-package branch from 670eade to ee050b0 Compare April 4, 2026 17:19
@provokateurin
Copy link
Copy Markdown
Member Author

Also updated the .gitmodules

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the chore/remove-nextcloud-package branch from ee050b0 to 0b6bdc0 Compare April 5, 2026 08:05
@provokateurin
Copy link
Copy Markdown
Member Author

We can't actually remove the git submodules, because they are also used to generate assets.

@provokateurin provokateurin marked this pull request as draft April 5, 2026 16:07
@Leptopoda
Copy link
Copy Markdown
Member

Does it make sense to move the asset generation to a separate package in the nextcloud.dart repo?
I'm thinking about nextcloud_assets.

But I agree that this might be a longshot goal.

@provokateurin
Copy link
Copy Markdown
Member Author

That doesn't help here. I will add back the ones that are still used for asset generation, the others can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants