Skip to content

test(user-picker): fix PHPUnit 12 dataprovider deprecations#58492

Merged
susnux merged 2 commits intomasterfrom
jtr/fix-user-picker-dataprovider-deps
Feb 23, 2026
Merged

test(user-picker): fix PHPUnit 12 dataprovider deprecations#58492
susnux merged 2 commits intomasterfrom
jtr/fix-user-picker-dataprovider-deps

Conversation

@joshtrichards
Copy link
Copy Markdown
Member

@joshtrichards joshtrichards commented Feb 21, 2026

  • Resolves: #

Summary

Eliminates PHPUnit deprecation notices (due to @dataProvider use) that were introduced via #57539:

There were 5 PHPUnit test runner deprecations:

1) Metadata found in doc-comment for method OCA\UserPicker\Reference\ProfilePickerReferenceProviderTest::testResolveReference(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

2) Metadata found in doc-comment for method OCA\UserPicker\Reference\ProfilePickerReferenceProviderTest::testMatchReference(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

3) Metadata found in doc-comment for method OCA\UserPicker\Reference\ProfilePickerReferenceProviderTest::testGetCacheKey(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

4) Metadata found in doc-comment for method OCA\UserPicker\Reference\ProfilePickerReferenceProviderTest::testGetObjectId(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

5) Metadata found in doc-comment for method OCA\UserPicker\Reference\ProfilePickerReferenceProviderTest::testGetOpenStreetLocationUrl(). Metadata in doc-comments is deprecated and will no longer be supported in PHPUnit 12. Update your test code to use attributes instead.

TODO

  • ...

Checklist

Eliminates PHPUnit deprecation notices (due to @dataProvider use) that were introduced via #57539.

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards requested a review from a team as a code owner February 21, 2026 02:48
@joshtrichards joshtrichards requested review from Altahrim, ArtificialOwl, come-nc and icewind1991 and removed request for a team February 21, 2026 02:48
@joshtrichards joshtrichards added this to the Nextcloud 34 milestone Feb 21, 2026
@joshtrichards joshtrichards added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 tests Related to tests labels Feb 21, 2026
Signed-off-by: Josh <josh.t.richards@gmail.com>
@susnux susnux enabled auto-merge February 22, 2026 15:22
@susnux susnux merged commit 974c82a into master Feb 23, 2026
174 checks passed
@susnux susnux deleted the jtr/fix-user-picker-dataprovider-deps branch February 23, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews technical debt 🧱 🤔🚀 tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants