Skip to content

test(user-picker): fix PHPUnit 12 dataprovider deprecations #58492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Feb 23, 2026
Merged

test(user-picker): fix PHPUnit 12 dataprovider deprecations #58492

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07c614d
test(user-picker): fix PHPUnit 12 dataprovider deprecations
joshtrichards Feb 21, 2026
24ffcd7
test(user-picker): add DataProvider use statement
joshtrichards Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions apps/user_picker/tests/unit/Reference/ProfilePickerReferenceProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
use OCP\IUser;
use OCP\IUserManager;
use OCP\Profile\IProfileManager;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\MockObject\MockObject;

class ProfilePickerReferenceProviderTest extends \Test\TestCase {
Expand Down Expand Up @@ -273,9 +274,8 @@ private function setupUserAccountReferenceExpectation(string $userId): ?IReferen

/**
* Resolved reference should contain the expected reference fields according to account property scope
*
* @dataProvider resolveReferenceDataProvider
*/
#[DataProvider('resolveReferenceDataProvider')]
public function testResolveReference($expected, $reference, $userId) {
if (isset($userId)) {
$expectedReference = $this->setupUserAccountReferenceExpectation($userId);
Expand All @@ -291,15 +291,15 @@ public function testGetId() {
}

/**
* @dataProvider referenceDataProvider
*/
#[DataProvider('referenceDataProvider')]
public function testMatchReference($expected, $reference) {
$this->assertEquals($expected, $this->referenceProvider->matchReference($reference));
}

/**
* @dataProvider cacheKeyDataProvider
*/
#[DataProvider('cacheKeyDataProvider')]
public function testGetCacheKey($expected, $reference) {
$this->assertEquals($expected, $this->referenceProvider->getCacheKey($reference));
}
Expand All @@ -319,16 +319,15 @@ public function testGetTitle() {
/**
* Test getObjectId method.
* It should return the userid extracted from the link (http(s)://domain.com/(index.php)/u/{userid}).
*
* @dataProvider objectIdDataProvider
*/
#[DataProvider('objectIdDataProvider')]
public function testGetObjectId($expected, $reference) {
$this->assertEquals($expected, $this->referenceProvider->getObjectId($reference));
}

/**
* @dataProvider locationDataProvider
*/
#[DataProvider('locationDataProvider')]
public function testGetOpenStreetLocationUrl($expected, $location) {
$this->assertEquals($expected, $this->referenceProvider->getOpenStreetLocationUrl($location));
}
Expand Down
Loading