Open
Conversation
Signed-off-by: Grigory V <scratchx@gmx.com>
GVodyanov
added
3. to review
GVodyanov
requested review from
ChristophWurst,
nfebe,
sorbaugh and
susnux
and removed request for
a team,
nfebe,
sorbaugh and
susnux
susnux
reviewed
Apr 6, 2026
| */ | ||
| #body-public { | ||
| --footer-height: calc(2lh + 2 * var(--default-grid-baseline)); // Set the initial value, will be updated programmatically to match the actual height | ||
| --footer-height: calc(4lh + 2 * var(--default-grid-baseline)); // Set the initial value (generous estimate for mobile wrapping), will be updated programmatically to match the actual height |
Contributor
There was a problem hiding this comment.
why is this needed? Usual use case is everything fits into 2lh and also for this case it seems it does not change anything.
| width: fit-content; | ||
| max-width: 90vw; | ||
| width: 90vw; | ||
| box-sizing: border-box; |
Contributor
There was a problem hiding this comment.
But this is always applied? Not only mobile.
Why not simply:
(so only adjust the width attribute)
Suggested change
| box-sizing: border-box; | |
| width: max-content; | |
| max-width: 90vw; |
Should then work on every viewport size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)AI (if applicable)