Skip to content

fix(public.scss): increase footer width #59452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GVodyanov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(public.scss): increase footer width #59452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions core/css/public.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
#body-public {
--footer-height: calc(2lh + 2 * var(--default-grid-baseline)); // Set the initial value, will be updated programmatically to match the actual height
--footer-height: calc(4lh + 2 * var(--default-grid-baseline)); // Set the initial value (generous estimate for mobile wrapping), will be updated programmatically to match the actual height
Copy link
Copy Markdown
Contributor

@susnux susnux Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed? Usual use case is everything fits into 2lh and also for this case it seems it does not change anything.


.header-end {
#header-primary-action a {
Expand Down Expand Up @@ -73,8 +73,8 @@
left: 50%;
bottom: var(--body-container-margin);
transform: translateX(-50%);
width: fit-content;
max-width: 90vw;
width: 90vw;
box-sizing: border-box;
Copy link
Copy Markdown
Contributor

@susnux susnux Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is always applied? Not only mobile.
Why not simply:
(so only adjust the width attribute)

Suggested change
box-sizing: border-box;
width: max-content;
max-width: 90vw;

Should then work on every viewport size.


&.guest-box {
// Ensure the maxcontrast color is set for the background
Expand All @@ -86,6 +86,7 @@
box-shadow: 0 0 10px var(--color-box-shadow);
-webkit-backdrop-filter: var(--filter-background-blur);
backdrop-filter: var(--filter-background-blur);
text-align: center;

.info {
text-shadow: none;
Expand Down
Loading