Fix: Migrate tests to GdUnit4#125
Conversation
Fixes #108 - Installed GdUnit4 addon - Migrated all test suites to use GdUnit4 macros - Replaced run_all_tests.sh with GdUnitCmdTool.gd - Updated GitHub Actions to use official GdUnit4 action - Fixed broken UI test states and headless compatibility
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates the GdUnit4 unit testing framework into the project, replacing the previous custom test runner and updating the PR template, documentation, and contributing guidelines accordingly. The review feedback highlights several critical issues across the newly added scripts, including syntax errors in GDScript (such as invalid spaces in assignment operators and the use of else: if instead of elif), potential runtime crashes due to missing null checks (e.g., when scene() or FileAccess.open returns null, or when returning null in builder pattern methods), and bash anti-patterns in runtest.sh regarding argument expansion. Additionally, the feedback points out a typo in GdUnitTestCIRunner.gd and a logic flaw in GdUnitTestSessionRunner.gd where tests are executed even if the startup hook fails.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Jules fix this PR CI issue |
1 participant
Closes #108
Migrates all legacy tests to GdUnit4, modernizing the test suite according to the industry standard.