Docs: Create ARCHITECTURE.md#126
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates the GdUnit4 unit testing framework into the project, replacing legacy shell-based testing with robust test suites, runners, and assertions. The code review identified several critical issues in the newly added framework files: potential runtime crashes in GdObjects.gd and GdUnitSceneRunnerImpl.gd due to missing validity checks on freed objects and loaded scenes; a redundant directory opening and potential null dereference in GdUnitFileAccess.gd; a strict typing mismatch in GdScriptParser.gd where a base Token is returned instead of a Variable; and a logic gap in GdUnitTestSessionRunner.gd where tests are executed even if the session startup hook fails.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Fixes #80 - Added comprehensive system overview - Documented 2.5D visual layer and state machines - Updated testing section to reflect recent GdUnit4 migration
aed3ec0 to
0de1325
Compare
Fixes #80
Adds comprehensive architectural documentation for Emberfall, including sections on the visual 2.5D system, deterministic math, FSMs, and the updated GdUnit4 testing methodology.