esm,loader: make evaluation errors catchable#44396
Closed
JakobJingleheimer wants to merge 1 commit intonodejs:mainfrom
Closed
esm,loader: make evaluation errors catchable#44396JakobJingleheimer wants to merge 1 commit intonodejs:mainfrom
JakobJingleheimer wants to merge 1 commit intonodejs:mainfrom
Conversation
JakobJingleheimer
added
esm
Collaborator
|
Review requested:
|
ljharb
reviewed
Aug 25, 2022
| const namespaces = await PromiseAll(new SafeArrayIterator(jobs)); | ||
| const namespaces = await PromisePrototypeCatch( | ||
| PromiseAll(new SafeArrayIterator(jobs)), | ||
| (err) => { throw err; }, // Make errors catchable in a custom loader. |
Member
There was a problem hiding this comment.
this is the default catch handler - I’m not sure why this has any effect?
Member
Author
There was a problem hiding this comment.
Now I'm confused: it wasn't working before this, I add it, it's working, I remove it, it's still working.
Contributor
There was a problem hiding this comment.
Yeah it's probably something else that changed on your end, this change should have no effect on the catchability of errors.
Member
Author
There was a problem hiding this comment.
Weird. I can't explain it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, an error thrown during module job evaluation is uncatchable. Such errors should be catchable in a custom loader.