Deploys the library-org service from a pre-built upstream docker container#490
Open
elevated-pasta-cat wants to merge 4 commits intomasterfrom
Open
Deploys the library-org service from a pre-built upstream docker container#490elevated-pasta-cat wants to merge 4 commits intomasterfrom
elevated-pasta-cat wants to merge 4 commits intomasterfrom
Conversation
SuperQ
reviewed
Apr 11, 2026
SuperQ
reviewed
Apr 11, 2026
Comment on lines
+20
to
+39
| - name: install docker engine | ||
| apt: | ||
| name: docker.io | ||
| state: present | ||
| update_cache: true | ||
| when: library_org_docker_check.rc != 0 | ||
|
|
||
| - name: install docker compose plugin | ||
| apt: | ||
| name: docker-compose-v2 | ||
| state: present | ||
| update_cache: true | ||
| when: library_org_compose_check.rc != 0 | ||
|
|
||
| - name: install python docker module | ||
| apt: | ||
| package: | ||
| - python3-pip | ||
| - python3-setuptools | ||
| - python3-virtualenv | ||
|
|
||
| - name: create group | ||
| group: | ||
| name: library-org | ||
| system: true | ||
| name: python3-docker | ||
| state: present | ||
| update_cache: true | ||
| when: library_org_pydocker_check.rc != 0 |
Collaborator
There was a problem hiding this comment.
We can simplify this:
Also, I would prefer to use Podman for our setup. Functions the same, but lighter weight (no daemon).
Suggested change
| - name: install docker engine | |
| apt: | |
| name: docker.io | |
| state: present | |
| update_cache: true | |
| when: library_org_docker_check.rc != 0 | |
| - name: install docker compose plugin | |
| apt: | |
| name: docker-compose-v2 | |
| state: present | |
| update_cache: true | |
| when: library_org_compose_check.rc != 0 | |
| - name: install python docker module | |
| apt: | |
| package: | |
| - python3-pip | |
| - python3-setuptools | |
| - python3-virtualenv | |
| - name: create group | |
| group: | |
| name: library-org | |
| system: true | |
| name: python3-docker | |
| state: present | |
| update_cache: true | |
| when: library_org_pydocker_check.rc != 0 | |
| - name: install podman container engine | |
| ansible.builtin.package: | |
| name: | |
| - podman | |
| - podman-compose | |
| - python3-podman | |
| state: present | |
| update_cache: true |
Contributor
Author
There was a problem hiding this comment.
Haha I was just thinking the same thing re podman.
SuperQ
reviewed
Apr 11, 2026
Remove docker infra checks during deploy Co-authored-by: Ben Kochie <superq@gmail.com>
switch to podman from docker Co-authored-by: Ben Kochie <superq@gmail.com>
Co-authored-by: Ben Kochie <superq@gmail.com>
SuperQ
reviewed
Apr 11, 2026
| failed_when: false | ||
|
|
||
| - name: remove legacy systemd unit | ||
| file: |
Collaborator
There was a problem hiding this comment.
Let's do fully-qualified Ansible names for all of these. Eventually I would like to crank up the Ansible Lint level.
Suggested change
| file: | |
| ansible.builtin.file: |
Contributor
Author
There was a problem hiding this comment.
Alright let me take a closer look. I'm migrating this to use podman entirely rather than relying on docker compose. Any objections?
Collaborator
There was a problem hiding this comment.
Sure, there's also a podman compose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on noisebridge/library-org#76