Skip to content

add setup scripts and migrate to uv#76

Open
elevated-pasta-cat wants to merge 7 commits intomasterfrom
migrate-to-uv
Open

add setup scripts and migrate to uv#76
elevated-pasta-cat wants to merge 7 commits intomasterfrom
migrate-to-uv

Conversation

@elevated-pasta-cat
Copy link
Copy Markdown

@elevated-pasta-cat elevated-pasta-cat commented Apr 6, 2026

I like uv, it's fast and the lock file makes it easier to guarantee python dependencies. In the future I would like to refactor the python code for readability & package-ability.

@elevated-pasta-cat elevated-pasta-cat self-assigned this Apr 6, 2026
Copy link
Copy Markdown
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should include the setup scripts. They're too OS-specific. I'd rather just maintain the Dockerfile as the "setup" process.

Comment thread controller.py Outdated
Copy link
Copy Markdown
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the uv refactor, don't forget to cleanup the old requirements file.

@elevated-pasta-cat
Copy link
Copy Markdown
Author

I don't think we should include the setup scripts. They're too OS-specific. I'd rather just maintain the Dockerfile as the "setup" process.

Ok fair enough. I was hoping to add ruff and pylint (just for errors) as pre-commit hooks. I'll update the read me to communicate that this is an option.

I don't mind the uv refactor, don't forget to cleanup the old requirements file.

Will do!

@SuperQ
Copy link
Copy Markdown
Contributor

SuperQ commented Apr 6, 2026

So one thing to note, we currently depend on the requirements.txt for production.

We have a couple options:

  • Update the ansible role to support uv.
  • Update the ansible role to use a container.

I'm somewhat in favor of migrating to a container anyway, so maybe we should do this first. Just need to finish setting up the CI to actually publish on ghcr.io.

@elevated-pasta-cat
Copy link
Copy Markdown
Author

So one thing to note, we currently depend on the requirements.txt for production.

We have a couple options:

  • Update the ansible role to support uv.
  • Update the ansible role to use a container.

I'm somewhat in favor of migrating to a container anyway, so maybe we should do this first. Just need to finish setting up the CI to actually publish on ghcr.io.

Thanks for calling this out. I can take a look at the CI and containerized deploy if you're not already working on that.

@SuperQ
Copy link
Copy Markdown
Contributor

SuperQ commented Apr 6, 2026

I had already been working on the CI. I got a PR read.

If you want to work on the Ansible side, that'd be great.

@elevated-pasta-cat
Copy link
Copy Markdown
Author

I had already been working on the CI. I got a PR read.

If you want to work on the Ansible side, that'd be great.

Sounds good. I'll review your code & work on the deploy after work today.

@elevated-pasta-cat
Copy link
Copy Markdown
Author

Alright @SuperQ here's my PR to deploy library-org with docker noisebridge/infrastructure#490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants