add setup scripts and migrate to uv#76
Conversation
SuperQ
left a comment
There was a problem hiding this comment.
I don't think we should include the setup scripts. They're too OS-specific. I'd rather just maintain the Dockerfile as the "setup" process.
SuperQ
left a comment
There was a problem hiding this comment.
I don't mind the uv refactor, don't forget to cleanup the old requirements file.
Ok fair enough. I was hoping to add ruff and pylint (just for errors) as pre-commit hooks. I'll update the read me to communicate that this is an option.
Will do! |
|
So one thing to note, we currently depend on the requirements.txt for production. We have a couple options:
I'm somewhat in favor of migrating to a container anyway, so maybe we should do this first. Just need to finish setting up the CI to actually publish on ghcr.io. |
Thanks for calling this out. I can take a look at the CI and containerized deploy if you're not already working on that. |
|
I had already been working on the CI. I got a PR read. If you want to work on the Ansible side, that'd be great. |
Sounds good. I'll review your code & work on the deploy after work today. |
|
Alright @SuperQ here's my PR to deploy library-org with docker noisebridge/infrastructure#490 |
a0ef018 to
babacd7
Compare
I like uv, it's fast and the lock file makes it easier to guarantee python dependencies. In the future I would like to refactor the python code for readability & package-ability.