fix: align flat command diagnostics#606
Conversation
Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
…g migration to module
* refactor: remove backlog ownership from core cli * fix: align CI marketplace validation paths * test: stabilize command audit validation and add command-surface change --------- Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
# Conflicts: # openspec/CHANGE_ORDER.md # openspec/changes/module-migration-10-bundle-command-surface-alignment/proposal.md
* fix: finalize cli runtime validation regressions * test: align satisfied dependency logging assertions --------- Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
* feat: add OpenSpec change for backlog-core commands migration Change: backlog-02-migrate-core-commands - Add proposal, design, tasks, specs - Add TDD_EVIDENCE.md with implementation progress - GitHub Issue: #389 Rules applied: AGENTS.md Git Worktree Policy, TDD Hard Gate Made-with: Cursor * docs: update TDD_EVIDENCE and tasks for quality gate results Made-with: Cursor * docs: update TDD_EVIDENCE with test fix results Made-with: Cursor * docs: update TDD_EVIDENCE with all test fixes complete Made-with: Cursor --------- Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
* fix: use POST instead of PATCH for ADO work item creation Azure DevOps API requires POST (not PATCH) for creating work items. Also fixed category grouping to always register group commands. Made-with: Cursor * docs: add changelog entry for ADO POST fix Made-with: Cursor * chore: bump version to 0.40.4 Made-with: Cursor * fix: update test mocks from PATCH to POST for ADO create - Reverted incorrect unconditional _mount_installed_category_groups call - Updated test_create_issue mocks to use requests.post instead of requests.patch Made-with: Cursor * test: skip category group test when bundles not installed The test_bootstrap_with_category_grouping_disabled_registers_flat_commands test expects bundles like specfact-codebase to be installed, but in CI they may not be. Added pytest.skip() when 'code' command is not available. Made-with: Cursor --------- Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
- Archived backlog-02-migrate-core-commands change - Updated CHANGE_ORDER.md with implementation status - Updated main specs with backlog-add, backlog-analyze-deps, backlog-delta, backlog-sync, backlog-verify-readiness Made-with: Cursor
* feat: document code-review module scaffold * chore: sync 0.41.0 release version artifacts --------- Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
Signed-off-by: Dom <39115308+djm81@users.noreply.github.com>
* Realign code import ownership surface * Harden temp registry command audit test --------- Signed-off-by: Dom <39115308+djm81@users.noreply.github.com> Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
Link the existing change issue, record TDD evidence, and align the OpenSpec artifacts with the bundle-owned DDL and paired worktree implementation flow. Made-with: Cursor Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
Made-with: Cursor Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
* Track house-rules skill OpenSpec changes Made-with: Cursor * Cursor: Apply local changes for cloud agent --------- Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dom <39115308+djm81@users.noreply.github.com>
* Add clean code cleanup docs change * docs: position SpecFact as AI-bloat defense CLI * docs: address PR review wording --------- Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
Co-authored-by: Dominikus Nold <djm81@users.noreply.github.com>
|
Strix is installed on this repository, but we could not run this PR security review because this workspace does not have an active plan. If you'd like to continue receiving code reviews, you can add a payment method or manage billing here. |
📝 WalkthroughCLI Surface & User-Visible Behavior
Contract / API Impact
Testing & Quality Gates
Versioning, Changelog & Release Hygiene
OpenSpec & Documentation
Notes & Follow-ups
WalkthroughAdds CLI root-token guidance to treat removed flat aliases as removed (not module diagnostics), quotes Hatch ChangesCLI diagnostics & tooling fixes (0.47.6)
Sequence Diagram(s)sequenceDiagram
participant User
participant TyperRootGroup
participant PatchResolver as _patch_missing_bundle_resolution
participant Guidance as _resolve_root_command_with_guidance
User->>TyperRootGroup: run root-token (e.g., `specfact validate --help`)
TyperRootGroup->>PatchResolver: get_command / resolve_command (patched)
PatchResolver->>Guidance: classify token (removed vs canonical)
alt removed alias
Guidance->>User: emit removed-alias guidance (mention canonical grouped command)
else canonical bundle unresolved
Guidance->>User: emit actionable missing-bundle/module guidance
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related issues
Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
SpecFact CLI Validation Report✅ All validations passed! |
djm81
added
bug
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 253e14c501
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openspec/changes/cli-removed-flat-alias-diagnostics/CHANGE_VALIDATION.md`:
- Line 52: In CHANGE_VALIDATION.md remove or redact the host-specific absolute
artifact path
`/Users/dom/.lean-ctx/tee/2026-06-09_232654_hatch_run_python_-m_pytest_tests_integra.log`
and replace it with a portable placeholder (e.g. `<ARTIFACT_LOG_PATH>`), a
relative path, or a sanitized example path to avoid leaking local
user/workstation identifiers; ensure the replacement preserves meaning for
validation evidence and update any nearby text that references the original
path.
In `@tests/integration/test_category_group_routing.py`:
- Around line 134-138: The test currently asserts a single exact phrase ("no
such command") in the variable output which is brittle; update the final
assertion to accept common wording variants by asserting that output matches any
of a small set of expected phrases (e.g., "no such command", "not a valid
command", "no such cmd", etc.) using a regex search (re.search) or an any(...)
over substrings and make it case-insensitive; keep the other assertions
unchanged and operate on the same variable name output.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d86e2ae3-f23b-4480-b7bd-1965613de87e
📒 Files selected for processing (20)
CHANGELOG.mddocs/_config.ymldocs/validation-integration.mdopenspec/changes/cli-removed-flat-alias-diagnostics/CHANGE_VALIDATION.mdopenspec/changes/cli-removed-flat-alias-diagnostics/TDD_EVIDENCE.mdopenspec/changes/cli-removed-flat-alias-diagnostics/proposal.mdopenspec/changes/cli-removed-flat-alias-diagnostics/specs/cli-error-guidance/spec.mdopenspec/changes/cli-removed-flat-alias-diagnostics/tasks.mdopenspec/changes/tooling-spaced-env-pythonpath/TDD_EVIDENCE.mdopenspec/changes/tooling-spaced-env-pythonpath/proposal.mdopenspec/changes/tooling-spaced-env-pythonpath/specs/trustworthy-green-checks/spec.mdopenspec/changes/tooling-spaced-env-pythonpath/tasks.mdpyproject.tomlsetup.pysrc/__init__.pysrc/specfact_cli/__init__.pysrc/specfact_cli/cli.pytests/integration/test_category_group_routing.pytests/unit/packaging/test_core_package_includes.pytests/unit/registry/test_category_groups.py
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
nold-ai/specfact-cli-modules(manual)
💤 Files with no reviewable changes (1)
- tests/unit/registry/test_category_groups.py
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Tests (Python 3.12)
- GitHub Check: Socket Security: Pull Request Alerts
🧰 Additional context used
📓 Path-based instructions (19)
**/*.py
📄 CodeRabbit inference engine (.cursor/rules/python-github-rules.mdc)
**/*.py: Maintain minimum 80% test coverage, with 100% coverage for critical paths in Python code
Use clear naming and self-documenting code, preferring clear names over comments
Ensure each function/class has a single clear purpose (Single Responsibility Principle)
Extract common patterns to avoid code duplication (DRY principle)
Apply SOLID object-oriented design principles in Python code
Use type hints everywhere in Python code and enable basedpyright strict mode
Use Pydantic models for data validation and serialization in Python
Use async/await for I/O operations in Python code
Use context managers for resource management in Python
Use dataclasses for simple data containers in Python
Enforce maximum line length of 120 characters in Python code
Use 4 spaces for indentation in Python code (no tabs)
Use 2 blank lines between classes and 1 blank line between methods in Python
Organize imports in order: Standard library → Third party → Local in Python files
Use snake_case for variables and functions in Python
Use PascalCase for class names in Python
Use UPPER_SNAKE_CASE for constants in Python
Use leading underscore (_) for private methods in Python classes
Use snake_case for Python file names
Enable basedpyright strict mode with strict type checking configuration in Python
Use Google-style docstrings for functions and classes in Python
Include comprehensive exception handling with specific exception types in Python code
Use logging with structured context (extra parameters) instead of print statements
Use retry logic with tenacity decorators (@retry) for operations that might fail
Use Pydantic BaseSettings for environment-based configuration in Python
Validate user input using Pydantic validators in Python models
Use@lru_cacheand Redis-based caching for expensive calculations in Python
Run code formatting with Black (120 character line length) and isort in Python
Run type checking with basedpyright on all Python files
Run linting with ruff and pylint on all Pyth...
Files:
setup.pysrc/__init__.pysrc/specfact_cli/__init__.pytests/unit/packaging/test_core_package_includes.pytests/integration/test_category_group_routing.pysrc/specfact_cli/cli.py
{src/__init__.py,pyproject.toml,setup.py}
📄 CodeRabbit inference engine (.cursor/rules/python-github-rules.mdc)
{src/__init__.py,pyproject.toml,setup.py}: Update src/init.py first as primary source of truth for package version, then pyproject.toml and setup.py
Maintain version synchronization across src/init.py, pyproject.toml, and setup.py
Files:
setup.pysrc/__init__.pypyproject.toml
{pyproject.toml,setup.py,src/__init__.py}
📄 CodeRabbit inference engine (.cursor/rules/testing-and-build-guide.mdc)
Manually update version numbers in pyproject.toml, setup.py, and src/init.py when making a formal version change
Files:
setup.pysrc/__init__.pypyproject.toml
**/*.{py,pyi}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{py,pyi}: After any code changes, follow these steps in order: (1) Apply linting and formatting to ensure code quality:hatch run format, (2) Type checking:hatch run type-check(basedpyright), (3) Contract-first approach: Runhatch run contract-testfor contract validation, (4) Run full test suite:hatch test --cover -v, (5) Verify all tests pass and contracts are satisfied, (6) Fix any issues and repeat steps until all tests pass
All public APIs must have@icontractdecorators and@beartypetype checking
Use Pydantic models for all data structures with data validation
Only write high-value comments if at all. Avoid talking to the user through comments
Files:
setup.pysrc/__init__.pysrc/specfact_cli/__init__.pytests/unit/packaging/test_core_package_includes.pytests/integration/test_category_group_routing.pysrc/specfact_cli/cli.py
src/**/*.py
📄 CodeRabbit inference engine (.cursor/rules/spec-fact-cli-rules.mdc)
src/**/*.py: All code changes must be followed by running the full test suite using the smart test system.
All Python files in src/ and tools/ directories must have corresponding test files in tests/ directory. If you modify src/common/logger_setup.py, you MUST have tests/unit/common/test_logger_setup.py. NO EXCEPTIONS - even small changes require tests.
All new Python runtime code files must have corresponding test files created BEFORE committing the code. NO EXCEPTIONS - no code without tests.
Test Coverage Validation: Run hatch run smart-test-unit for modified files, hatch run smart-test-folder for modified directories, and hatch run smart-test-full before committing. ALL TESTS MUST PASS.
All components must support TEST_MODE=true environment variable with test-specific behavior defined as: if os.environ.get('TEST_MODE') == 'true': # test-specific behavior
Use src/common/logger_setup.py for all logging via: from common.logger_setup import get_logger; logger = get_logger(name)
Use src/common/redis_client.py with fallback for Redis operations via: from common.redis_client import get_redis_client; redis_client = get_redis_client()
Type checking must pass with no errors using: mypy .
Test coverage must meet or exceed 80% total coverage. New code must have corresponding tests. Modified code must maintain or improve coverage. Critical paths must have 100% coverage.
Use Pydantic v2 validation for all context and data schemas.Add/update contracts on new or modified public APIs, stateful classes and adapters using
icontractdecorators andbeartyperuntime type checks
src/**/*.py: Meaningful Naming — identifiers reveal intent; avoid abbreviations. Identifiers insrc/must usesnake_case(modules/functions),PascalCase(classes),UPPER_SNAKE_CASE(constants). Avoid single-letter names outside short loop variables.
KISS — keep functions and modules small and single-purpose. Maximum function length: 120 lines (Phase A error threshold). Maximum cyclomati...
Files:
src/__init__.pysrc/specfact_cli/__init__.pysrc/specfact_cli/cli.py
@(src|tests)/**/*.py
📄 CodeRabbit inference engine (.cursor/rules/spec-fact-cli-rules.mdc)
Linting must pass with no errors using: pylint src tests
Files:
src/__init__.pysrc/specfact_cli/__init__.pytests/unit/packaging/test_core_package_includes.pytests/integration/test_category_group_routing.pysrc/specfact_cli/cli.py
src/specfact_cli/**/*.py
⚙️ CodeRabbit configuration file
src/specfact_cli/**/*.py: Focus on modular CLI architecture: lazy module loading, registry/bootstrap patterns, and
dependency direction. Flag breaking changes to public APIs, Pydantic models, and resource
bundling. Verify@icontract+@beartypeon public surfaces; prefer centralized logging
(get_bridge_logger) over print().
Files:
src/specfact_cli/__init__.pysrc/specfact_cli/cli.py
**/*.{md,mdc}
📄 CodeRabbit inference engine (.cursor/rules/markdown-rules.mdc)
**/*.{md,mdc}: Do not use more than one consecutive blank line anywhere in the document (MD012: No Multiple Consecutive Blank Lines)
Fenced code blocks should be surrounded by blank lines (MD031: Fenced Code Blocks)
Lists should be surrounded by blank lines (MD032: Lists)
Files must end with a single empty line (MD047: Files Must End With Single Newline)
Lines should not have trailing spaces (MD009: No Trailing Spaces)
Use asterisks (**) for strong emphasis, not underscores (__) (MD050: Strong Style)
Fenced code blocks must have a language specified (MD040: Fenced Code Language)
Headers should increment by one level at a time (MD001: Header Increment)
Headers should be surrounded by blank lines (MD022: Headers Should Be Surrounded By Blank Lines)
Only one top-level header (H1) is allowed per document (MD025: Single H1 Header)
Use consistent list markers, preferring dashes (-) for unordered lists (MD004: List Style)
Nested unordered list items should be indented consistently, typically by 2 spaces (MD007: Unordered List Indentation)
Use exactly one space after the list marker (e.g., -, *, +, 1.) (MD030: Spaces After List Markers)
Use incrementing numbers for ordered lists (MD029: Ordered List Item Prefix)
Enclose bare URLs in angle brackets or format them as links (MD034: Bare URLs)
Don't use spaces immediately inside code spans (MD038: Spaces Inside Code Spans)
Use consistent indentation (usually 2 or 4 spaces) throughout markdown files
Keep line length under 120 characters in markdown files
Use reference-style links for better readability in markdown files
Use a trailing slash for directory paths in markdown files
Ensure proper escaping of special characters in markdown files
Files:
openspec/changes/tooling-spaced-env-pythonpath/proposal.mdopenspec/changes/tooling-spaced-env-pythonpath/specs/trustworthy-green-checks/spec.mddocs/validation-integration.mdopenspec/changes/cli-removed-flat-alias-diagnostics/CHANGE_VALIDATION.mdopenspec/changes/cli-removed-flat-alias-diagnostics/tasks.mdopenspec/changes/tooling-spaced-env-pythonpath/tasks.mdopenspec/changes/tooling-spaced-env-pythonpath/TDD_EVIDENCE.mdopenspec/changes/cli-removed-flat-alias-diagnostics/TDD_EVIDENCE.mdopenspec/changes/cli-removed-flat-alias-diagnostics/proposal.mdopenspec/changes/cli-removed-flat-alias-diagnostics/specs/cli-error-guidance/spec.mdCHANGELOG.md
**/*.md
📄 CodeRabbit inference engine (.cursorrules)
Avoid markdown linting errors (refer to markdown-rules)
Files:
openspec/changes/tooling-spaced-env-pythonpath/proposal.mdopenspec/changes/tooling-spaced-env-pythonpath/specs/trustworthy-green-checks/spec.mddocs/validation-integration.mdopenspec/changes/cli-removed-flat-alias-diagnostics/CHANGE_VALIDATION.mdopenspec/changes/cli-removed-flat-alias-diagnostics/tasks.mdopenspec/changes/tooling-spaced-env-pythonpath/tasks.mdopenspec/changes/tooling-spaced-env-pythonpath/TDD_EVIDENCE.mdopenspec/changes/cli-removed-flat-alias-diagnostics/TDD_EVIDENCE.mdopenspec/changes/cli-removed-flat-alias-diagnostics/proposal.mdopenspec/changes/cli-removed-flat-alias-diagnostics/specs/cli-error-guidance/spec.mdCHANGELOG.md
openspec/changes/**/*.md
📄 CodeRabbit inference engine (.cursorrules)
For
/opsx:archive(Archive change): Include module signing and cleanup in final tasks. Agents MUST runopenspec archive <change-id>from repo root (no manualmvunderopenspec/changes/archive/)
Files:
openspec/changes/tooling-spaced-env-pythonpath/proposal.mdopenspec/changes/tooling-spaced-env-pythonpath/specs/trustworthy-green-checks/spec.mdopenspec/changes/cli-removed-flat-alias-diagnostics/CHANGE_VALIDATION.mdopenspec/changes/cli-removed-flat-alias-diagnostics/tasks.mdopenspec/changes/tooling-spaced-env-pythonpath/tasks.mdopenspec/changes/tooling-spaced-env-pythonpath/TDD_EVIDENCE.mdopenspec/changes/cli-removed-flat-alias-diagnostics/TDD_EVIDENCE.mdopenspec/changes/cli-removed-flat-alias-diagnostics/proposal.mdopenspec/changes/cli-removed-flat-alias-diagnostics/specs/cli-error-guidance/spec.md
openspec/**/{proposal.md,tasks.md,design.md,spec.md}
📄 CodeRabbit inference engine (.cursor/rules/automatic-openspec-workflow.mdc)
openspec/**/{proposal.md,tasks.md,design.md,spec.md}: Applyopenspec/config.yamlproject context and per-artifact rules (for proposal, specs, design, tasks) when creating or updating any OpenSpec change artifact in the specfact-cli codebase
After implementation, validate the change withopenspec validate <change-id> --strict; fix validation errors in proposal, specs, design, or tasks and re-validate until passing before considering the change complete
Files:
openspec/changes/tooling-spaced-env-pythonpath/proposal.mdopenspec/changes/tooling-spaced-env-pythonpath/specs/trustworthy-green-checks/spec.mdopenspec/changes/cli-removed-flat-alias-diagnostics/tasks.mdopenspec/changes/tooling-spaced-env-pythonpath/tasks.mdopenspec/changes/cli-removed-flat-alias-diagnostics/proposal.mdopenspec/changes/cli-removed-flat-alias-diagnostics/specs/cli-error-guidance/spec.md
openspec/**/*.md
⚙️ CodeRabbit configuration file
openspec/**/*.md: Treat as specification source of truth: proposal/tasks/spec deltas vs. code behavior,
CHANGE_ORDER consistency, and scenario coverage. Surface drift between OpenSpec and
implementation.
Files:
openspec/changes/tooling-spaced-env-pythonpath/proposal.mdopenspec/changes/tooling-spaced-env-pythonpath/specs/trustworthy-green-checks/spec.mdopenspec/changes/cli-removed-flat-alias-diagnostics/CHANGE_VALIDATION.mdopenspec/changes/cli-removed-flat-alias-diagnostics/tasks.mdopenspec/changes/tooling-spaced-env-pythonpath/tasks.mdopenspec/changes/tooling-spaced-env-pythonpath/TDD_EVIDENCE.mdopenspec/changes/cli-removed-flat-alias-diagnostics/TDD_EVIDENCE.mdopenspec/changes/cli-removed-flat-alias-diagnostics/proposal.mdopenspec/changes/cli-removed-flat-alias-diagnostics/specs/cli-error-guidance/spec.md
**/*.{yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/testing-and-build-guide.mdc)
Validate YAML configuration files locally using
hatch run yaml-lintbefore committing
**/*.{yml,yaml}: Format all YAML and workflow files usinghatch run yaml-fix-allbefore committing
Use Prettier to fix whitespace, indentation, and final newline across YAML files
Use yamllint with the repo .yamllint configuration (line-length 140, trailing spaces and final newline enforced) to lint non-workflow YAML files
Files:
docs/_config.yml
docs/**/*.md
📄 CodeRabbit inference engine (.cursor/rules/spec-fact-cli-rules.mdc)
Update architecture documentation in docs/ for architecture changes, state machine documentation for FSM modifications, interface documentation for API changes, and configuration guides for configuration changes. DO NOT create internal docs in specfact-cli repo folder that should not be visible to end users; use the respective internal repository instead.
Files:
docs/validation-integration.md
⚙️ CodeRabbit configuration file
docs/**/*.md: User-facing accuracy: CLI examples match current behavior; preserve Jekyll front matter;
call out when README/docs index need sync.
Files:
docs/validation-integration.md
**/test_*.py
📄 CodeRabbit inference engine (.cursor/rules/python-github-rules.mdc)
**/test_*.py: Write tests first in test-driven development (TDD) using the Red-Green-Refactor cycle
Ensure each test is independent and repeatable with no shared state between tests
Organize Python imports in tests using unittest.mock for Mock and patch
Use setup_method() for test initialization and Arrange-Act-Assert pattern in test files
Use@pytest.mark.asynciodecorator for async test functions in Python
Organize test files in structure: tests/unit/, tests/integration/, tests/e2e/ by module
Files:
tests/unit/packaging/test_core_package_includes.pytests/integration/test_category_group_routing.py
tests/**/*.py
📄 CodeRabbit inference engine (.cursor/rules/spec-fact-cli-rules.mdc)
Tests must be meaningful and test actual functionality, cover both success and failure cases, be independent and repeatable, and have clear, descriptive names. NO EXCEPTIONS - no placeholder or empty tests.
tests/**/*.py: Trim low-value unit tests when a contract covers the same assertion (type/shape/raises on negative checks)
Delete tests that only assert input validation, datatype/shape enforcement, or raises on negative conditions now guarded by contracts and runtime typing
Convert repeated edge-case permutations into one Hypothesis property with contracts acting as oraclesSecret redaction via
LoggerSetup.redact_secretsmust be covered by unit tests
Files:
tests/unit/packaging/test_core_package_includes.pytests/integration/test_category_group_routing.py
⚙️ CodeRabbit configuration file
tests/**/*.py: Contract-first testing: meaningful scenarios, not redundant assertions already covered by
contracts. Flag flakiness, environment coupling, and missing coverage for changed behavior.
Files:
tests/unit/packaging/test_core_package_includes.pytests/integration/test_category_group_routing.py
CHANGELOG.md
📄 CodeRabbit inference engine (.cursor/rules/python-github-rules.mdc)
Include new version entries at the top of CHANGELOG.md when updating versions
Update CHANGELOG.md with all code changes as part of version control requirements.
Update CHANGELOG.md to document all significant changes under Added, Fixed, Changed, or Removed sections when making a version change
Files:
CHANGELOG.md
pyproject.toml
📄 CodeRabbit inference engine (.cursorrules)
When updating the version in
pyproject.toml, ensure it's newer than the latest PyPI version. The CI/CD pipeline will automatically publish to PyPI only if the new version is greater than the published version
Files:
pyproject.toml
**/*cli*.{py,pyi}
📄 CodeRabbit inference engine (.cursorrules)
Commands should follow typer patterns with rich console output
Files:
src/specfact_cli/cli.py
🔀 Multi-repo context nold-ai/specfact-cli-modules
nold-ai/specfact-cli-modules
-
docs bundles reference removed flat verbs (affects user guidance/examples):
- docs/bundles/spec/validate.md — mentions specfact validate examples. [::nold-ai/specfact-cli-modules::docs/bundles/spec/validate.md]
- docs/bundles/codebase/plan.md / docs/bundles/codebase/repro.md / docs/bundles/codebase/drift.md / docs/bundles/codebase/analyze.md — bundle docs referencing plan/repro/drift/analyze verbs. [::nold-ai/specfact-cli-modules::docs/bundles/codebase/overview.md] (see related bundle files listed in tree)
- docs/reference/commands.md and docs/reference/commands.generated.md — command docs present many flat-token mentions (search hits across docs). [::nold-ai/specfact-cli-modules::docs/reference/commands.md]
-
Tests and scripts that reference flat aliases and command-path expectations (potentially need updates or confirm compatibility with PR behavior):
- tests/unit/test_specfact_project_manifest_commands.py — asserts "plan" in commands. [::nold-ai/specfact-cli-modules::tests/unit/test_specfact_project_manifest_commands.py]
- tests/unit/test_global_cli_error_contract.py — asserts "analyze" present in CLI error contract output. [::nold-ai/specfact-cli-modules::tests/unit/test_global_cli_error_contract.py]
- tests/unit/test_check_prompt_commands_script.py — contains multiple assertions ensuring removed flat prefixes (e.g., ("specfact","sync"), ("specfact","plan"), ("specfact","migrate")) are not present and validates prompt examples referencing flat commands. [::nold-ai/specfact-cli-modules::tests/unit/test_check_prompt_commands_script.py]
- tests/unit/test_bundle_resource_payloads.py — includes resource filenames like specfact.validate.md, specfact.02-plan.md, specfact.06-sync.md. These resource artifacts reference flat command examples. [::nold-ai/specfact-cli-modules::tests/unit/test_bundle_resource_payloads.py]
-
Tools/validation scripts that may surface CLI expectations:
- tools/validate_cli_contracts.py — used to validate CLI contract scenarios (mentions validate). Changes in CLI diagnostics could affect its outputs. [::nold-ai/specfact-cli-modules::tools/validate_cli_contracts.py]
Summary assessment
- This repository contains multiple docs, tests, and resource files that reference the flat aliases removed by the PR (validate, plan, analyze, drift, repro, sync, migrate). They are likely consumers of CLI surface/diagnostic behavior and should be audited to ensure examples/tests align with the new behavior (e.g., removed aliases reporting "no such command" rather than module diagnostics) and to update examples that previously used flat aliases.
🔇 Additional comments (16)
openspec/changes/tooling-spaced-env-pythonpath/proposal.md (1)
1-26: LGTM!openspec/changes/tooling-spaced-env-pythonpath/specs/trustworthy-green-checks/spec.md (1)
1-19: LGTM!openspec/changes/tooling-spaced-env-pythonpath/tasks.md (1)
1-21: LGTM!pyproject.toml (3)
7-7: LGTM!
227-227: LGTM!
229-229: LGTM!tests/unit/packaging/test_core_package_includes.py (1)
125-134: LGTM!openspec/changes/tooling-spaced-env-pythonpath/TDD_EVIDENCE.md (1)
1-17: LGTM!openspec/changes/cli-removed-flat-alias-diagnostics/proposal.md (1)
1-40: LGTM!openspec/changes/cli-removed-flat-alias-diagnostics/specs/cli-error-guidance/spec.md (1)
1-28: LGTM!openspec/changes/cli-removed-flat-alias-diagnostics/tasks.md (1)
1-28: LGTM!src/specfact_cli/cli.py (1)
187-230: LGTM!Also applies to: 901-903, 931-933
setup.py (1)
10-10: Verify 0.47.5 version synchronization and CHANGELOG entry
pyproject.toml,setup.py,src/__init__.py, andsrc/specfact_cli/__init__.pyall specify version0.47.5.CHANGELOG.mdcontains a## [0.47.5] - 2026-06-10entry, with related fixes listed.CHANGELOG.md (1)
13-30: LGTM!docs/_config.yml (1)
5-8: LGTM!docs/validation-integration.md (1)
27-27: Keepspecfact code validate sidecar runas the canonical command; align module docs/tests to the new no-flat-alias behavior.
docs/validation-integration.mdline 27 now correctly uses the grouped/canonical OpenSpec validation command (specfact code validate sidecar run), avoiding stale flat-alias guidance.In
nold-ai/specfact-cli-modules, earlier findings show still-stale flat-alias references that should be updated/rewired alongside this PR (e.g.,docs/bundles/spec/validate.md,docs/bundles/codebase/{plan,repro,drift,analyze}.md, and unit checks liketests/unit/test_check_prompt_commands_script.py/ CLI error-contract expectations). Ensure these changes are fully tracked innold-ai/specfact-cli-modules#317(or coordinate a separate follow-up if anything is missing).
- Removed flat root aliases (validate, plan, analyze, drift, repro, sync, migrate) now report 'No such command' with guidance to their canonical grouped replacement on all three root resolution surfaces (_RootCLIGroup, patched Typer root group, lazy delegate loader), per the cli-error-guidance spec scenario. - Deduplicate the root resolve/diagnostic logic into _resolve_root_command_with_guidance and _print_unresolved_root_token_help. - Update stale test test_stale_flat_shim_plan_exits_with_install_instructions (renamed ..._removed_alias_guidance) that caused the CI failures on Python 3.11/3.12; harden the shadowed-module regression assertions against unknown-command wording variants and assert canonical guidance. - Redact host-specific absolute paths from OpenSpec validation evidence. - Bump version artifacts to 0.47.6 with changelog entry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
SpecFact CLI Validation Report✅ All validations passed! |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_core_slimming.py (1)
172-183: 💤 Low valueTest name/docstring may be stale after diagnostic behavior change.
This test will pass because "plan" appears in the output, but the test name "exits_with_not_found_or_install_instructions" no longer accurately describes the new behavior. With
_REMOVED_FLAT_ALIAS_TO_CANONICAL, "plan" now shows "removed" guidance pointing tospecfact project, not install instructions.Consider renaming this test in a follow-up to align with
test_stale_flat_shim_plan_exits_with_removed_alias_guidanceor tightening assertions to explicitly verify "removed" and "project" are present.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_core_slimming.py` around lines 172 - 183, The test test_flat_shim_plan_exits_with_not_found_or_install_instructions no longer matches behavior after the _REMOVED_FLAT_ALIAS_TO_CANONICAL change; update it by either renaming it to test_stale_flat_shim_plan_exits_with_removed_alias_guidance or tightening its assertions to assert that result.exit_code != 0 and that the output contains the keywords "removed" and "project" (or explicit guidance text pointing to `specfact project`) instead of the previous "not installed"/"install" checks so the test reflects the new removed-alias messaging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_core_slimming.py`:
- Around line 172-183: The test
test_flat_shim_plan_exits_with_not_found_or_install_instructions no longer
matches behavior after the _REMOVED_FLAT_ALIAS_TO_CANONICAL change; update it by
either renaming it to
test_stale_flat_shim_plan_exits_with_removed_alias_guidance or tightening its
assertions to assert that result.exit_code != 0 and that the output contains the
keywords "removed" and "project" (or explicit guidance text pointing to
`specfact project`) instead of the previous "not installed"/"install" checks so
the test reflects the new removed-alias messaging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cd5aa7b8-80c4-4604-90c5-725912b4b416
📒 Files selected for processing (10)
CHANGELOG.mdopenspec/changes/cli-removed-flat-alias-diagnostics/CHANGE_VALIDATION.mdopenspec/changes/cli-removed-flat-alias-diagnostics/TDD_EVIDENCE.mdpyproject.tomlsetup.pysrc/__init__.pysrc/specfact_cli/__init__.pysrc/specfact_cli/cli.pytests/integration/test_category_group_routing.pytests/integration/test_core_slimming.py
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
nold-ai/specfact-cli-modules(manual)
✅ Files skipped from review due to trivial changes (4)
- openspec/changes/cli-removed-flat-alias-diagnostics/CHANGE_VALIDATION.md
- src/specfact_cli/init.py
- src/init.py
- openspec/changes/cli-removed-flat-alias-diagnostics/TDD_EVIDENCE.md
🚧 Files skipped from review as they are similar to previous changes (2)
- setup.py
- tests/integration/test_category_group_routing.py
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Linting (ruff, pylint, safe-write guard)
- GitHub Check: Type Checking (basedpyright)
- GitHub Check: Tests (Python 3.12)
- GitHub Check: Compatibility (Python 3.11)
- GitHub Check: CLI Command Validation
- GitHub Check: Analyze (python)
🧰 Additional context used
📓 Path-based instructions (14)
**/*.{md,mdc}
📄 CodeRabbit inference engine (.cursor/rules/markdown-rules.mdc)
**/*.{md,mdc}: Do not use more than one consecutive blank line anywhere in the document (MD012: No Multiple Consecutive Blank Lines)
Fenced code blocks should be surrounded by blank lines (MD031: Fenced Code Blocks)
Lists should be surrounded by blank lines (MD032: Lists)
Files must end with a single empty line (MD047: Files Must End With Single Newline)
Lines should not have trailing spaces (MD009: No Trailing Spaces)
Use asterisks (**) for strong emphasis, not underscores (__) (MD050: Strong Style)
Fenced code blocks must have a language specified (MD040: Fenced Code Language)
Headers should increment by one level at a time (MD001: Header Increment)
Headers should be surrounded by blank lines (MD022: Headers Should Be Surrounded By Blank Lines)
Only one top-level header (H1) is allowed per document (MD025: Single H1 Header)
Use consistent list markers, preferring dashes (-) for unordered lists (MD004: List Style)
Nested unordered list items should be indented consistently, typically by 2 spaces (MD007: Unordered List Indentation)
Use exactly one space after the list marker (e.g., -, *, +, 1.) (MD030: Spaces After List Markers)
Use incrementing numbers for ordered lists (MD029: Ordered List Item Prefix)
Enclose bare URLs in angle brackets or format them as links (MD034: Bare URLs)
Don't use spaces immediately inside code spans (MD038: Spaces Inside Code Spans)
Use consistent indentation (usually 2 or 4 spaces) throughout markdown files
Keep line length under 120 characters in markdown files
Use reference-style links for better readability in markdown files
Use a trailing slash for directory paths in markdown files
Ensure proper escaping of special characters in markdown files
Files:
CHANGELOG.md
CHANGELOG.md
📄 CodeRabbit inference engine (.cursor/rules/python-github-rules.mdc)
Include new version entries at the top of CHANGELOG.md when updating versions
Update CHANGELOG.md with all code changes as part of version control requirements.
Update CHANGELOG.md to document all significant changes under Added, Fixed, Changed, or Removed sections when making a version change
Files:
CHANGELOG.md
**/*.md
📄 CodeRabbit inference engine (.cursorrules)
Avoid markdown linting errors (refer to markdown-rules)
Files:
CHANGELOG.md
{src/__init__.py,pyproject.toml,setup.py}
📄 CodeRabbit inference engine (.cursor/rules/python-github-rules.mdc)
{src/__init__.py,pyproject.toml,setup.py}: Update src/init.py first as primary source of truth for package version, then pyproject.toml and setup.py
Maintain version synchronization across src/init.py, pyproject.toml, and setup.py
Files:
pyproject.toml
{pyproject.toml,setup.py,src/__init__.py}
📄 CodeRabbit inference engine (.cursor/rules/testing-and-build-guide.mdc)
Manually update version numbers in pyproject.toml, setup.py, and src/init.py when making a formal version change
Files:
pyproject.toml
pyproject.toml
📄 CodeRabbit inference engine (.cursorrules)
When updating the version in
pyproject.toml, ensure it's newer than the latest PyPI version. The CI/CD pipeline will automatically publish to PyPI only if the new version is greater than the published version
Files:
pyproject.toml
**/test_*.py
📄 CodeRabbit inference engine (.cursor/rules/python-github-rules.mdc)
**/test_*.py: Write tests first in test-driven development (TDD) using the Red-Green-Refactor cycle
Ensure each test is independent and repeatable with no shared state between tests
Organize Python imports in tests using unittest.mock for Mock and patch
Use setup_method() for test initialization and Arrange-Act-Assert pattern in test files
Use@pytest.mark.asynciodecorator for async test functions in Python
Organize test files in structure: tests/unit/, tests/integration/, tests/e2e/ by module
Files:
tests/integration/test_core_slimming.py
**/*.py
📄 CodeRabbit inference engine (.cursor/rules/python-github-rules.mdc)
**/*.py: Maintain minimum 80% test coverage, with 100% coverage for critical paths in Python code
Use clear naming and self-documenting code, preferring clear names over comments
Ensure each function/class has a single clear purpose (Single Responsibility Principle)
Extract common patterns to avoid code duplication (DRY principle)
Apply SOLID object-oriented design principles in Python code
Use type hints everywhere in Python code and enable basedpyright strict mode
Use Pydantic models for data validation and serialization in Python
Use async/await for I/O operations in Python code
Use context managers for resource management in Python
Use dataclasses for simple data containers in Python
Enforce maximum line length of 120 characters in Python code
Use 4 spaces for indentation in Python code (no tabs)
Use 2 blank lines between classes and 1 blank line between methods in Python
Organize imports in order: Standard library → Third party → Local in Python files
Use snake_case for variables and functions in Python
Use PascalCase for class names in Python
Use UPPER_SNAKE_CASE for constants in Python
Use leading underscore (_) for private methods in Python classes
Use snake_case for Python file names
Enable basedpyright strict mode with strict type checking configuration in Python
Use Google-style docstrings for functions and classes in Python
Include comprehensive exception handling with specific exception types in Python code
Use logging with structured context (extra parameters) instead of print statements
Use retry logic with tenacity decorators (@retry) for operations that might fail
Use Pydantic BaseSettings for environment-based configuration in Python
Validate user input using Pydantic validators in Python models
Use@lru_cacheand Redis-based caching for expensive calculations in Python
Run code formatting with Black (120 character line length) and isort in Python
Run type checking with basedpyright on all Python files
Run linting with ruff and pylint on all Pyth...
Files:
tests/integration/test_core_slimming.pysrc/specfact_cli/cli.py
tests/**/*.py
📄 CodeRabbit inference engine (.cursor/rules/spec-fact-cli-rules.mdc)
Tests must be meaningful and test actual functionality, cover both success and failure cases, be independent and repeatable, and have clear, descriptive names. NO EXCEPTIONS - no placeholder or empty tests.
tests/**/*.py: Trim low-value unit tests when a contract covers the same assertion (type/shape/raises on negative checks)
Delete tests that only assert input validation, datatype/shape enforcement, or raises on negative conditions now guarded by contracts and runtime typing
Convert repeated edge-case permutations into one Hypothesis property with contracts acting as oraclesSecret redaction via
LoggerSetup.redact_secretsmust be covered by unit tests
Files:
tests/integration/test_core_slimming.py
⚙️ CodeRabbit configuration file
tests/**/*.py: Contract-first testing: meaningful scenarios, not redundant assertions already covered by
contracts. Flag flakiness, environment coupling, and missing coverage for changed behavior.
Files:
tests/integration/test_core_slimming.py
@(src|tests)/**/*.py
📄 CodeRabbit inference engine (.cursor/rules/spec-fact-cli-rules.mdc)
Linting must pass with no errors using: pylint src tests
Files:
tests/integration/test_core_slimming.pysrc/specfact_cli/cli.py
**/*.{py,pyi}
📄 CodeRabbit inference engine (.cursorrules)
**/*.{py,pyi}: After any code changes, follow these steps in order: (1) Apply linting and formatting to ensure code quality:hatch run format, (2) Type checking:hatch run type-check(basedpyright), (3) Contract-first approach: Runhatch run contract-testfor contract validation, (4) Run full test suite:hatch test --cover -v, (5) Verify all tests pass and contracts are satisfied, (6) Fix any issues and repeat steps until all tests pass
All public APIs must have@icontractdecorators and@beartypetype checking
Use Pydantic models for all data structures with data validation
Only write high-value comments if at all. Avoid talking to the user through comments
Files:
tests/integration/test_core_slimming.pysrc/specfact_cli/cli.py
src/**/*.py
📄 CodeRabbit inference engine (.cursor/rules/spec-fact-cli-rules.mdc)
src/**/*.py: All code changes must be followed by running the full test suite using the smart test system.
All Python files in src/ and tools/ directories must have corresponding test files in tests/ directory. If you modify src/common/logger_setup.py, you MUST have tests/unit/common/test_logger_setup.py. NO EXCEPTIONS - even small changes require tests.
All new Python runtime code files must have corresponding test files created BEFORE committing the code. NO EXCEPTIONS - no code without tests.
Test Coverage Validation: Run hatch run smart-test-unit for modified files, hatch run smart-test-folder for modified directories, and hatch run smart-test-full before committing. ALL TESTS MUST PASS.
All components must support TEST_MODE=true environment variable with test-specific behavior defined as: if os.environ.get('TEST_MODE') == 'true': # test-specific behavior
Use src/common/logger_setup.py for all logging via: from common.logger_setup import get_logger; logger = get_logger(name)
Use src/common/redis_client.py with fallback for Redis operations via: from common.redis_client import get_redis_client; redis_client = get_redis_client()
Type checking must pass with no errors using: mypy .
Test coverage must meet or exceed 80% total coverage. New code must have corresponding tests. Modified code must maintain or improve coverage. Critical paths must have 100% coverage.
Use Pydantic v2 validation for all context and data schemas.Add/update contracts on new or modified public APIs, stateful classes and adapters using
icontractdecorators andbeartyperuntime type checks
src/**/*.py: Meaningful Naming — identifiers reveal intent; avoid abbreviations. Identifiers insrc/must usesnake_case(modules/functions),PascalCase(classes),UPPER_SNAKE_CASE(constants). Avoid single-letter names outside short loop variables.
KISS — keep functions and modules small and single-purpose. Maximum function length: 120 lines (Phase A error threshold). Maximum cyclomati...
Files:
src/specfact_cli/cli.py
**/*cli*.{py,pyi}
📄 CodeRabbit inference engine (.cursorrules)
Commands should follow typer patterns with rich console output
Files:
src/specfact_cli/cli.py
src/specfact_cli/**/*.py
⚙️ CodeRabbit configuration file
src/specfact_cli/**/*.py: Focus on modular CLI architecture: lazy module loading, registry/bootstrap patterns, and
dependency direction. Flag breaking changes to public APIs, Pydantic models, and resource
bundling. Verify@icontract+@beartypeon public surfaces; prefer centralized logging
(get_bridge_logger) over print().
Files:
src/specfact_cli/cli.py
🔀 Multi-repo context nold-ai/specfact-cli-modules
nold-ai/specfact-cli-modules
-
Documentation references removed flat verbs (examples or command lists):
- docs/bundles/spec/validate.md — contains examples mentioning
specfact validateand flat usage. [::nold-ai/specfact-cli-modules::docs/bundles/spec/validate.md] - docs/bundles/codebase/analyze.md, docs/bundles/codebase/drift.md, docs/bundles/codebase/repro.md — bundle docs reference
code analyze,code drift,code reproand related flat examples (search hits for flat verbs present). [::nold-ai/specfact-cli-modules::docs/bundles/codebase/analyze.md] [::nold-ai/specfact-cli-modules::docs/bundles/codebase/drift.md] [::nold-ai/specfact-cli-modules::docs/bundles/codebase/repro.md] - docs/reference/commands.md and docs/reference/commands.generated.md — command reference and generated command overview include many flat-token mentions and mapping rows (e.g., lists of top-level commands and examples). [::nold-ai/specfact-cli-modules::docs/reference/commands.md] [::nold-ai/specfact-cli-modules::docs/reference/commands.generated.md]
- docs/bundles/spec/validate.md — contains examples mentioning
-
Tests and test utilities that reference flat aliases or assert CLI contract details (may need updating to align with new removed-alias guidance):
- tests/unit/test_specfact_project_manifest_commands.py — asserts
planis present in module manifest commands. [::nold-ai/specfact-cli-modules::tests/unit/test_specfact_project_manifest_commands.py] - tests/unit/test_global_cli_error_contract.py — contains assertions expecting
analyzein CLI error output. [::nold-ai/specfact-cli-modules::tests/unit/test_global_cli_error_contract.py] - tests/unit/test_check_prompt_commands_script.py — validates prompt examples and includes expectations for flat verbs (e.g.,
specfact.validate,specfact repro,specfact sync). [::nold-ai/specfact-cli-modules::tests/unit/test_check_prompt_commands_script.py] - tests/unit/test_bundle_resource_payloads.py — includes resource filenames and prompt artifacts named after flat commands (e.g., specfact.validate.md, specfact.02-plan.md). [::nold-ai/specfact-cli-modules::tests/unit/test_bundle_resource_payloads.py]
- tests reference package manifests under packages/* (the project manifest test reads packages/specfact-project/module-package.yaml). These manifests may list flat commands. [::nold-ai/specfact-cli-modules::packages/specfact-project/module-package.yaml]
- tests/unit/test_specfact_project_manifest_commands.py — asserts
-
Scripts/tools that index or validate CLI contracts and prompt examples (consumers of CLI command surface):
- scripts/check-prompt-commands.py — extracts prompt command examples and validates them against a command index; will surface differences in removed vs module-diagnostic behavior. [::nold-ai/specfact-cli-modules::scripts/check-prompt-commands.py]
- tools/validate_cli_contracts.py — used to validate CLI contract scenarios (may need re-run/adjustment after CLI diagnostic behavior changes). [::nold-ai/specfact-cli-modules::tools/validate_cli_contracts.py]
Notes / quick implication:
- Multiple docs, prompt resources, tests, and validation scripts in this repo reference the flat aliases removed by the PR (validate, plan, analyze, drift, repro, sync, migrate). These are likely to need edits to examples, test expectations, or validation tooling to reflect that flat aliases now produce "removed/unknown" guidance instead of module-install/shadow diagnostics.
- The prompt-checking and CLI-contract validation tooling are direct consumers of the CLI surface and should be re-run/adjusted to avoid false positives from the new guidance behavior.
🔇 Additional comments (11)
CHANGELOG.md (1)
13-24: LGTM!pyproject.toml (2)
227-229: LGTM!
7-7: Version synchronization looks correct at 0.47.6
pyproject.toml/setup.py/src/__init__.py/src/specfact_cli/__init__.pyall report0.47.6, so the packaging version sources are aligned and safe.src/specfact_cli/cli.py (7)
115-125: LGTM!
169-177: LGTM!
180-188: LGTM!
191-212: LGTM!
219-220: LGTM!
231-238: LGTM!
624-632: LGTM!tests/integration/test_core_slimming.py (1)
186-212: LGTM!
1 participant
Summary
Fixes #605.
Follow-up
The former plan backlog-edit verbs and project migrate rehome are tracked separately in nold-ai/specfact-cli-modules#317. The local OpenSpec draft for that follow-up is intentionally not included in this PR.
Validation