fix(base): remove dangerous helm release options#302
Merged
sebastiancorrea81 merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
Removes force_update, atomic, cleanup_on_fail, replace, and recreate_pods which could cause resource deletion on failed upgrades. Also removes options that were already set to their Helm provider defaults (create_namespace, disable_webhooks, wait, reuse_values). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…es provider lock Updates nullplatform/nullplatform from 0.0.75 to 0.0.85 to match the ~> 0.0.76 constraint, and adds the hashicorp/kubernetes 3.1.0 lock entry required by the kubernetes_namespace_v1 resources. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
agustincelentano
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atomic,cleanup_on_fail,replace,force_update, andrecreate_podsfrom thehelm_release.baseresource — all were set totrueand could cause namespace/resource deletion on failed upgradescreate_namespace,disable_webhooks,wait,reuse_values), reducing noise and making intentional deviations explicitwait_for_jobs,timeout,reset_values,dependency_update,max_historyRoot cause
With
atomic = true+cleanup_on_fail = true+replace = true, a failedhelm upgradewould:cleanup_on_fail)atomic)replace)This caused namespaces and chart-managed resources to be deleted on upgrade failures.
Test plan
tofu planshows0 to destroyon upgradetofu applywith changed values shows~ update in-placeonly, no destroysfailed→deployed) with0 destroyed🤖 Generated with Claude Code