Skip to content

fix(base): remove dangerous helm release options #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastiancorrea81 merged 2 commits into from
Apr 23, 2026
Merged

fix(base): remove dangerous helm release options #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63f4c25
fix(base): remove dangerous helm release options and redundant defaults
Apr 23, 2026
6fed53a
chore(base): upgrade nullplatform provider to 0.0.85 and add kubernet…
Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 39 additions & 17 deletions nullplatform/base/.terraform.lock.hcl
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 0 additions & 9 deletions nullplatform/base/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,9 @@ resource "helm_release" "base" {
namespace = var.namespace
version = var.nullplatform_base_helm_version

create_namespace = false
disable_webhooks = false
force_update = true
wait = true
wait_for_jobs = true
timeout = 600
atomic = true
cleanup_on_fail = true
replace = true
recreate_pods = true
reset_values = true
reuse_values = false
dependency_update = true
max_history = 10
values = [local.nullplatform_base_values]
Expand Down
Loading