Avoid using issue title to improve PR title consistency#9863
Open
seanbudd wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions-based submission pipeline to stop using the originating issue title when creating the auto-generated pull request, aiming to make PR titles more consistent and less dependent on user-provided issue metadata.
Changes:
- Removed propagation of
issueTitlethrough workflow outputs/inputs. - Updated PR creation to use a deterministic title format (
Publish …) instead of the issue title. - Adjusted the workflow-call interface accordingly (removed the
issueTitleinput).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/sendJsonFile.yml |
Stops passing the issue title into the called workflow. |
.github/workflows/getData.js |
Removes setting an issueTitle output from the issue payload. |
.github/workflows/checkAndSubmitAddonMetadata.yml |
Removes issueTitle input and changes gh pr create title generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
145
to
+149
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| shell: pwsh | ||
| run: | | ||
| $prUrl = gh pr create --base master --head "${{ env.branchName }}" --title "${{ inputs.issueTitle }}" --body "Closes #${{ inputs.issueNumber }}" | ||
| $prUrl = gh pr create --base master --head "${{ env.branchName }}" --title "Publish ${{ needs.getAddonId.outputs.addonFileName }}" --body "Closes #${{ inputs.issueNumber }}" |
Member
Author
There was a problem hiding this comment.
the add-on file name should be relatively normalised, being it is extracted from an actual file name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.