Skip to content

Avoid using issue title to improve PR title consistency #9863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seanbudd wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −8
Open

Avoid using issue title to improve PR title consistency #9863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/checkAndSubmitAddonMetadata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ on:
issueAuthorName:
required: true
type: string
issueTitle:
required: true
type: string
secrets:
VT_API_KEY:
required: true
Expand Down Expand Up @@ -149,7 +146,7 @@ jobs:
GH_TOKEN: ${{ github.token }}
shell: pwsh
run: |
$prUrl = gh pr create --base master --head "${{ env.branchName }}" --title "${{ inputs.issueTitle }}" --body "Closes #${{ inputs.issueNumber }}"
$prUrl = gh pr create --base master --head "${{ env.branchName }}" --title "Publish ${{ needs.getAddonId.outputs.addonFileName }}" --body "Closes #${{ inputs.issueNumber }}"
$prNumber = ($prUrl.TrimEnd('/') -split '/')[-1]
"pullRequestNumber=$prNumber" >> $env:GITHUB_OUTPUT
- name: Create validation errors file
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/getData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
module.exports = ({context, core}) => {
// Allow identifying the issue later.
// setOutput exposes the variable for access at later stages via steps.get-data.outputs
//
const issueTitle = context.payload.issue.title
core.setOutput('issueTitle', issueTitle)
const issueNumber = context.payload.issue.number
core.setOutput('issueNumber', issueNumber)
// Knowing the submitter may be helpful
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/sendJsonFile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ jobs:
issueNumber: "${{ github.event.issue.number }}"
issueAuthorId: ${{ github.event.issue.user.id }}
issueAuthorName: ${{ github.event.issue.user.login }}
issueTitle: ${{ github.event.issue.title }}
secrets:
VT_API_KEY: ${{ secrets.VT_API_KEY }}
VIEWS_PUSH_TOKEN: ${{ secrets.VIEWS_PUSH_TOKEN }}
Loading