Skip to content

Set the Type radiobuttons in the Add Dictionary Entry dialog to be arranged vertically rather than horizontally#20347

Merged
seanbudd merged 1 commit into
betafrom
speech-dict-vertical-radiobuttons
Jun 16, 2026
Merged

Set the Type radiobuttons in the Add Dictionary Entry dialog to be arranged vertically rather than horizontally#20347
seanbudd merged 1 commit into
betafrom
speech-dict-vertical-radiobuttons

Conversation

@SaschaCowley

Copy link
Copy Markdown
Member

Link to issue number:

Temporary fix for #19657 

Summary of the issue:

The "Type" radio buttons in the "Add Dictionary Entry" dialog were displayed on a single line, causing the dialog to stretch off screen.

Description of user facing changes:

These radio buttons are now displayed in a single column rather than a single row.

Description of developer facing changes:

None

Description of development approach:

Set the radiobox's style to wx.RA_SPECIFY_ROWS. Also added a call to self.CentreOnParent to properly centre the dialog on its parent.

Testing strategy:

Ran from source and checked that the radio buttons were arranged vertically and the dialog was centred on the speech dictionary dialog.

Known issues with pull request:

This is a temporary fix, with the desired long-term fix being to convert to a combobox.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@SaschaCowley SaschaCowley requested a review from a team as a code owner June 16, 2026 02:36
@SaschaCowley SaschaCowley requested a review from seanbudd June 16, 2026 02:36
@SaschaCowley SaschaCowley added this to the 2026.2 milestone Jun 16, 2026
@seanbudd seanbudd merged commit 6d8272e into beta Jun 16, 2026
39 checks passed
@seanbudd seanbudd deleted the speech-dict-vertical-radiobuttons branch June 16, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants