ci: bump actions off deprecated Node 20; drop self-review workflow#6
Merged
Conversation
GitHub deprecates Node 20 actions on 2026-06-16. Bump to the current Node 24 majors: actions/checkout v4 -> v6 actions/setup-node v4 -> v6 pnpm/action-setup v4 -> v6 actions/upload-artifact v4 -> v7 actions/download-artifact v4 -> v8 (dtolnay/rust-toolchain is a composite action and Swatinem/rust-cache@v2 is already on Node 24, so both are left as-is.) Also removes the splus-review.yml dogfood workflow and its sole-consumer helper scripts/gh-annotate.mjs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub is forcing Node 20 actions onto Node 24 on 2026-06-16 and removing the Node 20 runtime on 2026-09-16 (changelog). The v0.8.1 release run flagged this on every build job.
Action bumps (verified against each action's latest release)
actions/checkoutactions/setup-nodepnpm/action-setupactions/upload-artifactactions/download-artifactLeft as-is on purpose:
dtolnay/rust-toolchain@stable— composite action, no Node runtime.Swatinem/rust-cache@v2— its current v2 release already runs on Node 24 (it was not in the deprecation warning).softprops/action-gh-release@v2— also not flagged; v3 is a major bump with no benefit here.Removed
.github/workflows/splus-review.yml(the self-review dogfood workflow).scripts/gh-annotate.mjs— its only consumer was that workflow, so it's now dead code.Validation
ci.ymlruns onpull_request, so the checkout/node/pnpm bumps are exercised by this PR's own checks.release.ymlonly runs on av*tag, so its artifact-action bumps (upload@v7+download@v8, both on the v4+ artifact backend, mutually compatible) are first exercised on the next release.Not in this PR: SonarCloud
The
SonarCloud Code Analysischeck is not defined anywhere in this repo — there's no workflow orsonar-project.properties. It's the external SonarCloud GitHub App running automatic analysis, so it can't be removed by a code change. To drop it, disable Automatic Analysis in the SonarCloud project (or uninstall the SonarCloud app from thekiwi-initorg).mainhas no branch protection, so it isn't a required check.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.