Skip to content

Add parents and children to omero obj#299

Closed
joshmoore wants to merge 1 commit into
ome:masterfrom
joshmoore:obj-hier
Closed

Add parents and children to omero obj#299
joshmoore wants to merge 1 commit into
ome:masterfrom
joshmoore:obj-hier

Conversation

@joshmoore

@joshmoore joshmoore commented Aug 18, 2021

Copy link
Copy Markdown
Member

@sbesson sbesson added this to the 5.12.0 milestone May 24, 2022
@will-moore

Copy link
Copy Markdown
Member

Trying to test locally after checking out this branch (strangely, this worked fine just now when testing #199):

$ pip uninstall omero-py
$ pip install -e .
$ omero login
Traceback (most recent call last):
  File "/Users/wmoore/opt/anaconda3/envs/omeroweb/bin/omero", line 33, in <module>
    sys.exit(load_entry_point('omero-py', 'console_scripts', 'omero')())
  File "/Users/wmoore/opt/anaconda3/envs/omeroweb/bin/omero", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/Users/wmoore/opt/anaconda3/envs/omeroweb/lib/python3.9/importlib/metadata.py", line 86, in load
    module = import_module(match.group('module'))
  File "/Users/wmoore/opt/anaconda3/envs/omeroweb/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 984, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'omero.main'

@joshmoore

Copy link
Copy Markdown
Member Author

Don't think that's related to this PR.

@joshmoore

Copy link
Copy Markdown
Member Author

NB: see related thoughts under https://github.com/ome/design/blob/master/OME001/index.md

@will-moore

Copy link
Copy Markdown
Member

I realise it's not related to this PR. It just means I can't test the PR.

@joshmoore

Copy link
Copy Markdown
Member Author

In coming back to this to try it myself, I realized that what I might actually want (or at least sometimes) is the entire hierarchy including intermediaries. The closest solution I could find to that was using duplicate, in case anyone has suggestions.

@sbesson

sbesson commented Mar 28, 2025

Copy link
Copy Markdown
Member

This is now conflicting with the changes to omero obj in #453. @will-moore @joshmoore how do you want to handle this?

@will-moore

Copy link
Copy Markdown
Member

One hack that I use for reporting graph traversal is to use omero delete Image:123 --dry-run --report (haven't tried duplicate but probably similar).

But as to this PR, I don't have a strong opinion

@joshmoore

Copy link
Copy Markdown
Member Author

Happy for #453 to go first then I can rebase.

--exclude

@sbesson

sbesson commented Feb 24, 2026

Copy link
Copy Markdown
Member

This will require work to fix the conflicts. Closing to remove from the active list of reviews, this can be reopened later if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants