Keep $clientID as deprecated alias alongside renamed $clientId

[Copilot]

PR #34 renames the public $clientID property to $clientId to fix PHP 8.2+ dynamic property deprecation, but silently breaks consumers accessing $client->clientID directly.

Changes

• src/OneLoginClient.php: Explicitly declare both $clientId (primary) and $clientID (deprecated alias), and assign both in the constructor to keep them in sync
• src/exceptions/OneLoginException.php: Make $previous parameter explicitly nullable (?\Throwable) to fix PHP 8.4 implicit nullable deprecation

/** @var string $clientId OneLogin Client ID */
public $clientId;

/** @deprecated Use $clientId instead */
public $clientID;

public function __construct(...)
{
    $this->clientId = $clientId;
    $this->clientID = $clientId; // deprecated alias, kept in sync
    ...
}

[Copilot]

Pull request overview

This PR restores backward compatibility after renaming the public OneLoginClient::$clientID property to ::$clientId (to avoid PHP 8.2+ dynamic property deprecations), and updates exception typing to avoid PHP 8.4 implicit-nullable deprecations.

Changes:

• Declare public $clientId while retaining public $clientID as a deprecated alias.
• Initialize the deprecated alias in the OneLoginClient constructor.
• Make OneLoginException’s $previous parameter explicitly nullable (?\Throwable).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/OneLoginClient.php	Adds the new clientId property and keeps clientID as a deprecated alias initialized in the constructor.
src/exceptions/OneLoginException.php	Updates constructor signature to use ?\Throwable $previous = null for PHP 8.4 compatibility.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.