Skip to content

Keep $clientID as deprecated alias alongside renamed $clientId #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Subterrane merged 4 commits into from
Jun 9, 2026
Merged

Keep $clientID as deprecated alias alongside renamed $clientId #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10658d4
Initial plan
Copilot Jun 9, 2026
2d3b4a5
fix: keep $clientID as deprecated alias in sync with $clientId, fix n…
Copilot Jun 9, 2026
ee3a214
keep properties consistent in both directions
Subterrane Jun 9, 2026
d632e72
documentation fix
Subterrane Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/OneLoginClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,12 @@ class OneLoginClient
/** @var GuzzleHttp\Client client */
protected $client;

/** @var string $clientID OneLogin Client ID */
/** @var string $clientId OneLogin Client ID */
public $clientId;

/** @var string $clientID OneLogin Client ID
* @deprecated Use $clientId instead
*/
public $clientID;

/** @var string $clientSecret OneLogin Client */
Expand Down Expand Up @@ -88,6 +93,7 @@ public function __construct($clientId, $clientSecret, $region = "us", $maxResult
{
$this->client = new Client();
$this->clientId = $clientId;
$this->clientID =& $this->clientId;
$this->clientSecret = $clientSecret;
Comment thread
Copilot marked this conversation as resolved.
$this->urlBuilder = new UrlBuilder($region);
$this->userAgent = OneLoginClient::CUSTOM_USER_AGENT;
Expand Down
2 changes: 1 addition & 1 deletion src/exceptions/OneLoginException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class OneLoginException extends \Exception
/** @var string $errorAttribute The attribute that caused the error if available */
protected $errorAttribute;

public function __construct($message = "", $code = 0, $errorAttribute = null, \Throwable $previous = null)
public function __construct($message = "", $code = 0, $errorAttribute = null, ?\Throwable $previous = null)
{
parent::__construct($message, $code, $previous);
$this->errorCode = $code;
Expand Down
Loading