feat: use io.github.gzsombor json logic lib#1779
feat: use io.github.gzsombor json logic lib#1779chrfwow wants to merge 1 commit intoopen-feature:mainfrom
Conversation
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
chrfwow
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the json-logic-java dependency in the pom.xml file to a different fork and version. A critical issue was identified where this change introduces a breaking package name shift, which will cause compilation errors in the project's Java source files unless the imports are updated accordingly.
| <groupId>io.github.gzsombor</groupId> | ||
| <artifactId>json-logic-java</artifactId> | ||
| <version>1.1.0</version> | ||
| <version>1.1.2</version> |
There was a problem hiding this comment.
Switching the dependency to io.github.gzsombor:json-logic-java version 1.1.2 is a breaking change. In this fork, the package name has been changed from io.github.jamsesso.jsonlogic to io.github.gzsombor.jsonlogic. The current implementation in JsonlogicProvider.java and JsonlogicProviderTest.java still uses the old package imports, which will cause compilation errors. Please update the imports and type references in all Java source files to match the new package name.
There was a problem hiding this comment.
Not true, the new lib still uses the old package name
2 participants
Ignore this for now, I just want to test the ci