Skip to content

feat: use io.github.gzsombor json logic lib #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chrfwow wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Draft

feat: use io.github.gzsombor json logic lib #1779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions providers/jsonlogic-eval-provider/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@

<dependencies>
<dependency>
<groupId>io.github.jamsesso</groupId>
<groupId>io.github.gzsombor</groupId>
<artifactId>json-logic-java</artifactId>
<version>1.1.0</version>
<version>1.1.2</version>
Comment on lines +35 to +37
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Switching the dependency to io.github.gzsombor:json-logic-java version 1.1.2 is a breaking change. In this fork, the package name has been changed from io.github.jamsesso.jsonlogic to io.github.gzsombor.jsonlogic. The current implementation in JsonlogicProvider.java and JsonlogicProviderTest.java still uses the old package imports, which will cause compilation errors. Please update the imports and type references in all Java source files to match the new package name.

Copy link
Copy Markdown
Contributor Author

@chrfwow chrfwow Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true, the new lib still uses the old package name

</dependency>
<dependency>
<groupId>org.json</groupId>
Expand Down
Loading