feat(otlp-http): improve endpoint handling, add User-Agent header, an…#2074
Open
arjun-rajappa wants to merge 2 commits into
Open
feat(otlp-http): improve endpoint handling, add User-Agent header, an…#2074arjun-rajappa wants to merge 2 commits into
arjun-rajappa wants to merge 2 commits into
Conversation
…d enhance metrics - Add spec-compliant default User-Agent header with exporter version and Ruby runtime info - Fix endpoint path construction to properly handle OTEL_EXPORTER_OTLP_ENDPOINT with/without trailing slashes - Implement proper endpoint precedence: explicit endpoint > OTEL_EXPORTER_OTLP_TRACES_ENDPOINT > OTEL_EXPORTER_OTLP_ENDPOINT - Add metrics for compressed and uncompressed message sizes - Add specific error handling and logging for 404 responses - Refactor endpoint and header preparation into dedicated methods - Prevent header mutation by duplicating Hash parameters - Add comprehensive test coverage for endpoint path handling and User-Agent header Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
arjun-rajappa
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd and
robertlaurin
as code owners
| compression: OpenTelemetry::Common::Utilities.config_opt('OTEL_EXPORTER_OTLP_TRACES_COMPRESSION', 'OTEL_EXPORTER_OTLP_COMPRESSION', default: 'gzip'), | ||
| timeout: OpenTelemetry::Common::Utilities.config_opt('OTEL_EXPORTER_OTLP_TRACES_TIMEOUT', 'OTEL_EXPORTER_OTLP_TIMEOUT', default: 10), | ||
| metrics_reporter: nil) | ||
| raise ArgumentError, "invalid url for OTLP::Exporter #{endpoint}" unless OpenTelemetry::Common::Utilities.valid_url?(endpoint) |
Contributor
There was a problem hiding this comment.
why remove this validation?
Contributor
Author
There was a problem hiding this comment.
| redo if backoff?(retry_count: retry_count += 1, reason: response.code) | ||
| FAILURE | ||
| when Net::HTTPNotFound | ||
| log_request_failure(response.code) |
Contributor
There was a problem hiding this comment.
There is no metrics support, OpenTelemetry.handle_error seems enough.
Contributor
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
| headers | ||
| end | ||
|
|
||
| def prepare_endpoint(endpoint) |
Contributor
There was a problem hiding this comment.
Thank you for adding protections for edge cases!
arjun-rajappa
force-pushed
the
add-tests-otlp-http
branch
2 times, most recently
from
63304ce to
96374cc
Compare
- Remove metrics_reporter parameter and all internal metrics recording - Remove private_constant declarations for KEEP_ALIVE_TIMEOUT, RETRY_COUNT, and ERROR_MESSAGE_INVALID_HEADERS - Simplify compression logic using ternary operator - Remove measure_request_duration method and inline request execution - Replace metrics recording with standard error logging in backoff - Remove metrics-related test case - Fix typo This change removes the internal metrics instrumentation from the OTLP HTTP trace exporter, simplifying the codebase and reducing dependencies. Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
arjun-rajappa
force-pushed
the
add-tests-otlp-http
branch
from
a968389 to
5db2fc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1667