Merged
Conversation
dfulu
approved these changes
Aug 15, 2025
Member
dfulu
left a comment
dfulu
left a comment
There was a problem hiding this comment.
There is one small thing, but looks good
tests/conftest.py
Outdated
|
|
||
|
|
||
| # This is important to avoid saving errors | ||
| for v in list(ds.coords.keys()): |
Member
There was a problem hiding this comment.
We don't need to loop through the coords if we are already looping through the variables below. The coords are included in the variables
Contributor
Author
There was a problem hiding this comment.
thanks, your right!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Upgrade packags and fix tests
How Has This Been Tested?
Ci tests
Checklist: