Skip to content

8385425: AArch64: Comment re set_and_get_current_sve_vector_length() is misleading#31278

Closed
gdams wants to merge 2 commits into
openjdk:masterfrom
gdams:re_set
Closed

8385425: AArch64: Comment re set_and_get_current_sve_vector_length() is misleading#31278
gdams wants to merge 2 commits into
openjdk:masterfrom
gdams:re_set

Conversation

@gdams

@gdams gdams commented May 26, 2026

Copy link
Copy Markdown
Member

See openjdk/jdk26u#205 (review) for context

CC @theRealAph



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8385425: AArch64: Comment re set_and_get_current_sve_vector_length() is misleading (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31278/head:pull/31278
$ git checkout pull/31278

Update a local copy of the PR:
$ git checkout pull/31278
$ git pull https://git.openjdk.org/jdk.git pull/31278/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31278

View PR using the GUI difftool:
$ git pr show -t 31278

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31278.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 26, 2026

Copy link
Copy Markdown

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 26, 2026

Copy link
Copy Markdown

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8385425: AArch64: Comment re set_and_get_current_sve_vector_length() is misleading

Reviewed-by: aph, macarte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph, @macarte) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot added the hotspot hotspot-dev@openjdk.org label May 26, 2026
@openjdk

openjdk Bot commented May 26, 2026

Copy link
Copy Markdown

@gdams The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented May 26, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 26, 2026

@theRealAph theRealAph left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mlbridge

mlbridge Bot commented May 26, 2026

Copy link
Copy Markdown

Webrevs

@macarte macarte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams

gdams commented May 26, 2026

Copy link
Copy Markdown
Member Author

/integrate

@openjdk openjdk Bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels May 26, 2026
@openjdk

openjdk Bot commented May 26, 2026

Copy link
Copy Markdown

@gdams
Your change (at version 16acb65) is now ready to be sponsored by a Committer.

@macarte

macarte commented May 26, 2026

Copy link
Copy Markdown
Contributor

/sponsor

@openjdk

openjdk Bot commented May 26, 2026

Copy link
Copy Markdown

Going to push as commit 0eede1c.
Since your change was applied there have been 5 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label May 26, 2026
@openjdk openjdk Bot closed this May 26, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 26, 2026
@openjdk

openjdk Bot commented May 26, 2026

Copy link
Copy Markdown

@macarte @gdams Pushed as commit 0eede1c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gdams gdams deleted the re_set branch May 26, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants