Skip to content

8381617: vm_version_windows_aarch64.cpp: PF_ARM_SVE_INSTRUCTIONS_AVAILABLE undeclared identifier#205

Open
gdams wants to merge 2 commits into
openjdk:pr/204from
gdams:8381617
Open

8381617: vm_version_windows_aarch64.cpp: PF_ARM_SVE_INSTRUCTIONS_AVAILABLE undeclared identifier#205
gdams wants to merge 2 commits into
openjdk:pr/204from
gdams:8381617

Conversation

@gdams

@gdams gdams commented May 20, 2026

Copy link
Copy Markdown
Member

The only diff between tip and jdk26u is the missing extra bug IDs. Otherwise this patch applies cleanly.

 * @test id=vanilla
- * @bug 8340093
+ * @bug 8340093 8342095 8381617
 * @summary Test vectorization of reduction loops.
 * @library /test/lib /
 * @run driver compiler.loopopts.superword.TestReductions P1
 */

/*
 * @test id=force-vectorization
- * @bug 8340093
+ * @bug 8340093 8342095 8381617
 * @summary Test vectorization of reduction loops.
 * @library /test/lib /
 * @run driver compiler.loopopts.superword.TestReductions P2
 */


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8381617 needs maintainer approval
  • JDK-8385425 needs maintainer approval
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #204 must be integrated first

Issues

  • JDK-8381617: vm_version_windows_aarch64.cpp: PF_ARM_SVE_INSTRUCTIONS_AVAILABLE undeclared identifier (Bug - P4 - Requested)
  • JDK-8385425: AArch64: Comment re set_and_get_current_sve_vector_length() is misleading (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk26u.git pull/205/head:pull/205
$ git checkout pull/205

Update a local copy of the PR:
$ git checkout pull/205
$ git pull https://git.openjdk.org/jdk26u.git pull/205/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 205

View PR using the GUI difftool:
$ git pr show -t 205

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk26u/pull/205.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 20, 2026

Copy link
Copy Markdown

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into pr/204 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 20, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 78e962592ff8612486dedb6dafd3a47bfe56bcf8 8381617: vm_version_windows_aarch64.cpp: PF_ARM_SVE_INSTRUCTIONS_AVAILABLE undeclared identifier May 20, 2026
@openjdk

openjdk Bot commented May 20, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 20, 2026
@mlbridge

mlbridge Bot commented May 20, 2026

Copy link
Copy Markdown

Webrevs

Comment thread src/hotspot/os_cpu/windows_aarch64/vm_version_windows_aarch64.cpp

@theRealAph theRealAph left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@gdams

gdams commented May 26, 2026

Copy link
Copy Markdown
Member Author

/approval request This backport combined with JDK-8371651 fixes two JTREG test failures on Linux aarch64 (and probably Windows aarch64)

@openjdk

openjdk Bot commented May 26, 2026

Copy link
Copy Markdown

@gdams
8381617: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label May 26, 2026
@theRealAph

Copy link
Copy Markdown

Can I ask for a favour, please? If you'll create a PR for head to fix the comment in question, I'll insta-approve it so we don't get out of sync.

https://bugs.openjdk.org/browse/JDK-8385425

@gdams

gdams commented May 26, 2026

Copy link
Copy Markdown
Member Author

Can I ask for a favour, please? If you'll create a PR for head to fix the comment in question, I'll insta-approve it so we don't get out of sync.

https://bugs.openjdk.org/browse/JDK-8385425

done! openjdk/jdk#31278

@gdams

gdams commented May 26, 2026

Copy link
Copy Markdown
Member Author

/issue add 8385425

@openjdk

openjdk Bot commented May 26, 2026

Copy link
Copy Markdown

@gdams
Adding additional issue to issue list: 8385425: AArch64: Comment re set_and_get_current_sve_vector_length() is misleading.

@bridgekeeper

bridgekeeper Bot commented Jun 24, 2026

Copy link
Copy Markdown

@gdams This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants