8263188: JSSE should fail fast if there isn't supported signature algorithm#811
8263188: JSSE should fail fast if there isn't supported signature algorithm#811jerboaa wants to merge 10 commits into
Conversation
8249159: Downport test rework for SSLSocketTemplate from 8224650
8246330: Add TLS Tests for Legacy ECDSA curves
8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl
8250839: Improve test template SSLEngineTemplate with SSLContextTemplate
8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
8263188: JSSE should fail fast if there isn't supported signature algorithm
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
GHA failures are: |
37e03ef to
7dcac35
Compare
|
@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch I'll update the PR once more of the dependent PRs get reviewed/integrated. Upon which I'll need to do some rebase/conflict resolution anyway. |
|
@jerboaa The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@jerboaa this pull request can not be integrated into git checkout jdk-8263188-jsse-fail-fast-8u-new3
git fetch https://git.openjdk.org/jdk8u-dev.git pr/810
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/810"
git push |
Please review this fairly low-risk backport to fail the TLS handshake early when there are no common signature algorithm. It also adds two new tests, which are changed in the JDK-8284047 test backport and it's useful for bringing in JDK-8340321 and JDK-8349583.
The JDK 11u patch applies cleanly (modulo path changes) after #810 however the
SigAlgosExtTestWithTLS12.javatest needed adaptations to compile. 1.) replaceMap.ofwith regularHashMapinstantiation and subsequentputfollowed byCollections.unmodifiableMap()in a static initializer 2) ByteBuffer.position() returnsBufferwhich then causes a comile fail when callingput. This doesn't seem to happen in 11u and up. I've added an explicit cast. See second commit which performs those changes.Testing:
jdk/test/javax/net/ssl,jdk/test/sun/net/www/protocol/https/andjdk/test/sun/security/ssl/tests with the following result:Test results: passed: 267; failed: 2; error: 1=> same failures as for master. Note the +2 passed tests from 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message #810 (265).Thoughts?
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/811/head:pull/811$ git checkout pull/811Update a local copy of the PR:
$ git checkout pull/811$ git pull https://git.openjdk.org/jdk8u-dev.git pull/811/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 811View PR using the GUI difftool:
$ git pr show -t 811Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/811.diff
Using Webrev
Link to Webrev Comment