Skip to content

8263188: JSSE should fail fast if there isn't supported signature algorithm#811

Open
jerboaa wants to merge 10 commits into
openjdk:pr/810from
jerboaa:jdk-8263188-jsse-fail-fast-8u-new3
Open

8263188: JSSE should fail fast if there isn't supported signature algorithm#811
jerboaa wants to merge 10 commits into
openjdk:pr/810from
jerboaa:jdk-8263188-jsse-fail-fast-8u-new3

Conversation

@jerboaa

@jerboaa jerboaa commented May 28, 2026

Copy link
Copy Markdown
Contributor

Please review this fairly low-risk backport to fail the TLS handshake early when there are no common signature algorithm. It also adds two new tests, which are changed in the JDK-8284047 test backport and it's useful for bringing in JDK-8340321 and JDK-8349583.

The JDK 11u patch applies cleanly (modulo path changes) after #810 however the SigAlgosExtTestWithTLS12.java test needed adaptations to compile. 1.) replace Map.of with regular HashMap instantiation and subsequent put followed by Collections.unmodifiableMap() in a static initializer 2) ByteBuffer.position() returns Buffer which then causes a comile fail when calling put. This doesn't seem to happen in 11u and up. I've added an explicit cast. See second commit which performs those changes.

Testing:

Thoughts?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8263188 needs maintainer approval

Integration blocker

 ⚠️ Dependency #810 must be integrated first

Issue

  • JDK-8263188: JSSE should fail fast if there isn't supported signature algorithm (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/811/head:pull/811
$ git checkout pull/811

Update a local copy of the PR:
$ git checkout pull/811
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/811/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 811

View PR using the GUI difftool:
$ git pr show -t 811

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/811.diff

Using Webrev

Link to Webrev Comment

jerboaa added 10 commits May 19, 2026 19:33
8249159: Downport test rework for SSLSocketTemplate from 8224650
8246330: Add TLS Tests for Legacy ECDSA curves
8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl
8250839: Improve test template SSLEngineTemplate with SSLContextTemplate
8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
8263188: JSSE should fail fast if there isn't supported signature algorithm
@bridgekeeper

bridgekeeper Bot commented May 28, 2026

Copy link
Copy Markdown

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/810 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 28, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 7441d3877f19c2c891ddddaba42f0819813f41eb 8263188: JSSE should fail fast if there isn't supported signature algorithm May 28, 2026
@openjdk

openjdk Bot commented May 28, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 28, 2026
@mlbridge

mlbridge Bot commented May 28, 2026

Copy link
Copy Markdown

Webrevs

@jerboaa

jerboaa commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

@bridgekeeper

bridgekeeper Bot commented Jun 25, 2026

Copy link
Copy Markdown

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jerboaa

jerboaa commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

/touch

I'll update the PR once more of the dependent PRs get reviewed/integrated. Upon which I'll need to do some rebase/conflict resolution anyway.

@openjdk

openjdk Bot commented Jun 26, 2026

Copy link
Copy Markdown

@jerboaa The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk

openjdk Bot commented Jun 26, 2026

Copy link
Copy Markdown

@jerboaa this pull request can not be integrated into pr/810 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout jdk-8263188-jsse-fail-fast-8u-new3
git fetch https://git.openjdk.org/jdk8u-dev.git pr/810
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/810"
git push

@openjdk openjdk Bot added the merge-conflict Pull request has merge conflict with target branch label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base merge-conflict Pull request has merge conflict with target branch rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant