Refactors the OpenSearch sink to split out the ingestion code from the rest#6795
Merged
dlvenable merged 1 commit intoopensearch-project:mainfrom May 6, 2026
Conversation
dlvenable
requested review from
KarstenSchnitter,
Zhangxunmt,
dinujoh,
divbok,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
dlvenable
force-pushed
the
opensearch-sink-ingester-refactor
branch
from
a6a5ca9 to
d1a9209
Compare
6 tasks
dlvenable
force-pushed
the
opensearch-sink-ingester-refactor
branch
from
d1a9209 to
e1df733
Compare
…her work such as index management. I plan to use this work to help support pull-based ingestion within this sink. This commit is just for refactoring since it is already significant. Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
force-pushed
the
opensearch-sink-ingester-refactor
branch
from
e1df733 to
cc6c5c5
Compare
Member
Author
|
The mTLS tests are new and are failing in https://github.com/opensearch-project/data-prepper/actions/runs/25442178408/job/74636200566 |
graytaylor0
approved these changes
May 6, 2026
Member
|
I see that some of the integration tests are failing with opensearch exceptions. I don't think these were failing previously. Edit: I see you called this out as an existing issue. Makes sense |
srikanthpadakanti
added a commit
to srikanthpadakanti/data-prepper
that referenced
this pull request
May 7, 2026
The connectionConfiguration local variable was moved out of doInitializeInternal scope by PR opensearch-project#6795. Use the getter from openSearchSinkConfig instead. Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
1 task
dlvenable
pushed a commit
that referenced
this pull request
May 7, 2026
Auto generate test PEM files at runtime using BouncyCastle Use @tempdir for PEM file cleanup instead of deleteOnExit The connectionConfiguration local variable was moved out of doInitializeInternal scope by PR #6795. Use the getter from openSearchSinkConfig instead. Fix mTLS integration test to present client cert on verification client The verification RestClient also needs to present a client certificate when OpenSearch has clientauth_mode: REQUIRE. Added a local client builder with client cert support. Also simplified the workflow mTLS config logic with prefix detection. Signed-off-by: Srikanth Padakanti <srikanth_padakanti@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm looking to update the
opensearchsink to support OpenSearch's pull-based indexing.As part of this work, I'm refactoring the
OpenSearchSinkclass by adding anIngesterinterface to handle the bulk of the data ingestion work. This separates concerns of index management, action determination, and ingestion.Issues Resolved
None. But this contributes toward #6796.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.