CORENET-7134: Add ovn-kubernetes toolset skeleton

[mattedallo]

Summary

Registers a new ovn-kubernetes toolset as scaffolding for OVN-Kubernetes networking diagnostics integration (enhancements#2002).

• Adds pkg/toolsets/ovnkubernetes/toolset.go — empty toolset implementing api.Toolset, registered via init()
• Adds blank import in pkg/mcp/modules.go
• Adds ovn-kubernetes to the TestGranularToolsetsTools snapshot test with an empty [] snapshot

The toolset ships with zero tools — sibling stories CORENET-7135 (OVS tools) and CORENET-7136 (OVN tools) will add tool handlers on top of this framework.

Verification

• make build — binary compiles with the new toolset
• make test — all tests pass (including the new snapshot test)
• make lint — no lint violations

What is NOT in this PR

• No tool implementations (deferred to CORENET-7135/7136/7137/7138)
• No ovn-kubernetes-mcp Go dependency (arrives with tool implementations)
• No execution adapter / pod-exec changes (depends on CORENET-7133)
• No README/docs update (zero tools means empty generated sections)

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced OVN-Kubernetes CNI network troubleshooting toolset, providing dedicated network diagnostic and troubleshooting capabilities for OVN-Kubernetes environments.

• Tests

  • Extended test coverage to include validation of the new OVN-Kubernetes toolset and its associated network troubleshooting tools.

[openshift-ci-robot]

@mattedallo: This pull request references CORENET-7134 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Registers a new ovn-kubernetes toolset as scaffolding for OVN-Kubernetes networking diagnostics integration (enhancements#2002).

• Adds pkg/toolsets/ovnkubernetes/toolset.go — empty toolset implementing api.Toolset, registered via init()
• Adds blank import in pkg/mcp/modules.go
• Adds ovn-kubernetes to the TestGranularToolsetsTools snapshot test with an empty [] snapshot

The toolset ships with zero tools — sibling stories CORENET-7135 (OVS tools) and CORENET-7136 (OVN tools) will add tool handlers on top of this framework.

Verification

• make build — binary compiles with the new toolset
• make test — all tests pass (including the new snapshot test)
• make lint — no lint violations

What is NOT in this PR

• No tool implementations (deferred to CORENET-7135/7136/7137/7138)
• No ovn-kubernetes-mcp Go dependency (arrives with tool implementations)
• No execution adapter / pod-exec changes (depends on CORENET-7133)
• No README/docs update (zero tools means empty generated sections)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8eb2c785-3497-4ae2-a1ce-2114ec30cd74

📥 Commits

Reviewing files that changed from the base of the PR and between 59efa78 and 1124f8a.

📒 Files selected for processing (4)

• pkg/mcp/modules.go
• pkg/mcp/testdata/toolsets-ovn-kubernetes-tools.json
• pkg/mcp/toolsets_test.go
• pkg/toolsets/ovnkubernetes/toolset.go

---

📝 Walkthrough

Walkthrough

This PR adds a new OVN-Kubernetes toolset to the OpenShift MCP server. It defines a toolset struct with network troubleshooting capabilities, registers it in the module system, and integrates it into the existing toolset test suite with snapshot validation.

Changes

OVN-Kubernetes Toolset

Layer / File(s)	Summary
OVN-Kubernetes Toolset Implementation pkg/toolsets/ovnkubernetes/toolset.go	Defines Toolset struct implementing api.Toolset with GetName() returning "ovn-kubernetes", GetDescription() returning "OVN-Kubernetes CNI network troubleshooting tools", and GetTools, GetPrompts, GetResources, GetResourceTemplates all returning nil. Registers via init().
Module Registration and Test Integration pkg/mcp/modules.go, pkg/mcp/toolsets_test.go, pkg/mcp/testdata/toolsets-ovn-kubernetes-tools.json	Side-effect import in modules.go enables toolset initialization. Test import and TestGranularToolsetsTools case addition expand snapshot coverage. Test data file provides empty JSON array snapshot.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A toolset for networks, with OVN's own flair,
Rabbits hop swiftly through troubleshooting care,
Snapshots and tests in a bundle so neat,
One more small hop makes the feature complete! 🐰🔧

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically summarizes the main change: adding a new ovn-kubernetes toolset skeleton with appropriate reference to the tracking ticket.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattedallo
Once this PR has been reviewed and has the lgtm label, please assign cali0707 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mattedallo]

/test all

[mattedallo]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[openshift-ci]

@mattedallo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[matzew]

seems pretty empty

why not land this with actual tools (e.g. as go module)?

[mattedallo]

Hi @matzew, thanks for reviewing!

Yep, we have a followup PRs coming for the tools.
But If you prefer I may add some of them into this PR directly.