Skip to content

CORENET-7134: Add ovn-kubernetes toolset skeleton #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattedallo wants to merge 1 commit into
base: main
Choose a base branch
from
+42 −0
Open

CORENET-7134: Add ovn-kubernetes toolset skeleton #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/mcp/modules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
_ "github.com/containers/kubernetes-mcp-server/pkg/toolsets/kubevirt"
_ "github.com/containers/kubernetes-mcp-server/pkg/toolsets/netedge"
_ "github.com/containers/kubernetes-mcp-server/pkg/toolsets/openshift"
_ "github.com/containers/kubernetes-mcp-server/pkg/toolsets/ovnkubernetes"
_ "github.com/containers/kubernetes-mcp-server/pkg/toolsets/tekton"
_ "github.com/rhobs/obs-mcp/pkg/toolset"
)
1 change: 1 addition & 0 deletions pkg/mcp/testdata/toolsets-ovn-kubernetes-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
2 changes: 2 additions & 0 deletions pkg/mcp/toolsets_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"github.com/containers/kubernetes-mcp-server/pkg/toolsets/kiali"
"github.com/containers/kubernetes-mcp-server/pkg/toolsets/kubevirt"
"github.com/containers/kubernetes-mcp-server/pkg/toolsets/openshift"
"github.com/containers/kubernetes-mcp-server/pkg/toolsets/ovnkubernetes"
"github.com/containers/kubernetes-mcp-server/pkg/toolsets/tekton"
"github.com/modelcontextprotocol/go-sdk/mcp"
"github.com/stretchr/testify/suite"
Expand Down Expand Up @@ -178,6 +179,7 @@ func (s *ToolsetsSuite) TestGranularToolsetsTools() {
&helm.Toolset{},
&kiali.Toolset{},
&kubevirt.Toolset{},
&ovnkubernetes.Toolset{},
&tekton.Toolset{},
}
for _, testCase := range testCases {
Expand Down
38 changes: 38 additions & 0 deletions pkg/toolsets/ovnkubernetes/toolset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package ovnkubernetes
Copy link
Copy Markdown
Member

@matzew matzew May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems pretty empty

why not land this with actual tools (e.g. as go module)?

Copy link
Copy Markdown
Author

@mattedallo mattedallo May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matzew, thanks for reviewing!

Yep, we have a followup PRs coming for the tools.
But If you prefer I may add some of them into this PR directly.

Copy link
Copy Markdown
Member

@matzew matzew May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - I'd think we do not land empty toolsets here

Copy link
Copy Markdown

@Cali0707 Cali0707 May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 let's at least try to land the first tool in this PR. If you want to then incrementally add some more tools in future PRs that is cool


import (
"github.com/containers/kubernetes-mcp-server/pkg/api"
"github.com/containers/kubernetes-mcp-server/pkg/toolsets"
)

type Toolset struct{}

var _ api.Toolset = (*Toolset)(nil)

func (t *Toolset) GetName() string {
return "ovn-kubernetes"
}

func (t *Toolset) GetDescription() string {
return "OVN-Kubernetes CNI network troubleshooting tools"
}

func (t *Toolset) GetTools(_ api.Openshift) []api.ServerTool {
return nil
}

func (t *Toolset) GetPrompts() []api.ServerPrompt {
return nil
}

func (t *Toolset) GetResources() []api.ServerResource {
return nil
}

func (t *Toolset) GetResourceTemplates() []api.ServerResourceTemplate {
return nil
}

func init() {
toolsets.Register(&Toolset{})
}