Skip to content

fix(misc): residual fabrication sweep across detail pages and providers#166

Merged
operatoruplift merged 1 commit intomasterfrom
residual-cleanup
Apr 27, 2026
Merged

fix(misc): residual fabrication sweep across detail pages and providers#166
operatoruplift merged 1 commit intomasterfrom
residual-cleanup

Conversation

@operatoruplift
Copy link
Copy Markdown
Owner

Closing the fabrication sweep

#147#155#156#157#162#164#165 covered the headline surfaces. This PR closes the loop on the last five files that carried fake telemetry or sci-fi cosplay branding.

Changes

app/(dashboard)/agents/[id]/page.tsx (helper detail)

Before After
3 demo helpers with sessions: 142 / 2847 / 89 and memoryUsage: '2.4GB' / '512MB' / '1.8GB', all status: 'running' Same 3 starters, all sessions: 0, memoryUsage: ',', status: 'idle'
5-event hardcoded ACTIVITY_LOG with timestamps ("Refactor auth middleware completed · 2m ago", "Memory indexed: 847 new embeddings · 1h ago", etc.) Empty array; panel renders "No activity yet. Run this helper to see results here."
"CodePilot Pro" / "Blackwall Guard" "Code Pilot" / "Security Guard" (last Blackwall reference in user-facing surfaces)

src/components/ui/CommandBar.tsx (cmd-K palette)

Before After
"Go to Agent Store" "Go to Helpers"
"Go to Agent Builder" "Go to Builder"
"Marketing homepage" "Public homepage"
"New Chat" / "Build Agent" "New chat" / "Build a helper"
Security entry description: "Blackwall security dashboard" "Encryption, receipts, and activity log"

app/(dashboard)/integrations/page.tsx

DD.xyz integration howItWorks:

  • Was: "Powers Blackwall threat assessment and compliance checks."
  • Now: "used by security and compliance helpers."

src/components/providers/AgentProvider.tsx

MOCK_AGENTS was 4 agents named "Founder Ops" / "Growth Lead" / "DevRel" / "Support Bot" with descriptions like "Orchestrating company operations" implying real ongoing background tasks. Now 4 helpers named for what they actually do: "Inbox helper", "Calendar helper", "Research helper", "Reminders". Default flipped from "founder-ops" → "inbox".

app/(dashboard)/onboarding/page.tsx

Starter helper renames: "CodePilot" → "Code Pilot", "Research Bot" → "Researcher", "Security Guard" desc rewritten to match agents/[id].

Trust impact

After this merges, a grep -rnE "Blackwall|CodePilot|Founder Ops|Warp Network|Uplift Core|Gold Agent" across src/ and app/ returns zero hits in user-facing surfaces. The only remaining match is the comment on notifications/page.tsx documenting what #165 removed.

Verified

pnpm exec tsc --noEmit  # exit 0
pnpm check              # 3 passed, 0 failed

Net diff

5 files changed, 39 insertions(+), 33 deletions(-)

Rollback

Single git revert.

Five more surfaces still carried fake telemetry or sci-fi cosplay
branding after #164/#165. This is the cleanup PR that closes the
sweep.

## Changes

### app/(dashboard)/agents/[id]/page.tsx (helper detail)

Was: 3 demo helpers with hardcoded
- `sessions: 142` / `2847` / `89`
- `memoryUsage: '2.4GB'` / '512MB' / '1.8GB'
- `status: 'running'`
plus a 5-event ACTIVITY_LOG with timestamps ("2m ago", "15m ago", etc.)
claiming each helper had "Refactor auth middleware completed",
"Memory indexed: 847 new embeddings", "Deployed from Agent Builder"
done on the user's account.

Now: same 3 helpers as starter detail pages but
- `sessions: 0`, `memoryUsage: ','`, `status: 'idle'`
- ACTIVITY_LOG empty by default; the panel renders an honest "No
  activity yet. Run this helper to see results here." placeholder
- "CodePilot Pro" -> "Code Pilot", "Blackwall Guard" -> "Security
  Guard" (last Blackwall reference in user-facing surfaces)

### src/components/ui/CommandBar.tsx (cmd-K palette)

Renamed entries to match the consumer/dashboard rewrites in #154/#163:
- "Go to Agent Store" -> "Go to Helpers"
- "Go to Agent Builder" -> "Go to Builder"
- "Marketing homepage" -> "Public homepage"
- "New Chat" -> "New chat"
- "Build Agent" -> "Build a helper"
- Security entry description "Blackwall security dashboard" ->
  "Encryption, receipts, and activity log"

### app/(dashboard)/integrations/page.tsx

DD.xyz integration `howItWorks` description rewrite. Was: "Powers
Blackwall threat assessment and compliance checks." Now: "used by
security and compliance helpers." (drops the Blackwall brand).

### src/components/providers/AgentProvider.tsx

`MOCK_AGENTS` was 4 agents named "Founder Ops" / "Growth Lead" /
"DevRel" / "Support Bot" with status "online" / "busy" / "offline"
and descriptions like "Orchestrating company operations" that
implied real ongoing operations on the user's account.

Now: 4 helpers named after what they actually do,
- "Inbox helper", "Calendar helper", "Research helper", "Reminders"
all with status "online" since they're available to run, not
pretending to be running tasks behind the scenes. Default activeAgent
flipped from "founder-ops" to "inbox" so the consumer use case is
front and center.

### app/(dashboard)/onboarding/page.tsx

Starter helper renames: "CodePilot" -> "Code Pilot", "Research Bot"
-> "Researcher", "Security Guard" desc rewrite to match
agents/[id]/page.tsx.

## Trust impact

Final pass on the fabrication class started in PR #147. After this
merges, a grep for "Blackwall|CodePilot|Founder Ops|Warp Network|
Uplift Core|Gold Agent" returns zero hits in user-facing surfaces.

## Verified

- pnpm exec tsc --noEmit: clean
- pnpm check: 3 passed, 0 failed
- Final fabrication sweep clean (only hit is the comment on
  notifications/page.tsx documenting what #165 removed)

## Rollback

Single git revert. Five files.
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
website Ready Ready Preview, Comment Apr 27, 2026 7:41am

@operatoruplift operatoruplift merged commit f19fd3b into master Apr 27, 2026
4 checks passed
operatoruplift added a commit that referenced this pull request Apr 27, 2026
…167)

Two improvements in one PR.

## (1) Trust-gate coverage 11/44 -> 16/44

Five small routes adopted the @/lib/apiHelpers withRequestMeta pattern
that the larger /api/tools/* routes already use (PR #123) and the
observability sweep extended to the receipts/memory/agents/
notifications/audit families (PR #130). Now every response from
these routes carries `X-Request-Id`, supporting the request-id
propagation contract trust-gate enforces.

Routes:
- app/api/providers/route.ts        (6 lines)
- app/api/capabilities/route.ts    (25 lines)
- app/api/receipts/public-key/route.ts (26 lines)
- app/api/health/llm/route.ts      (27 lines)
- app/api/dashboard/stats/route.ts (31 lines)

## (2) Fix the residual fabrication in /api/dashboard/stats

While adding apiHelpers I found one more fabrication leftover: when
the route's auth check fails, it was returning a hardcoded fallback
payload:

  {
    activeAgents: 14,
    chatSessions: 8,
    memoryNodes: 12400,
    securityBlocks: 47,
  }

These are the **exact same fake values** PR #164 removed from the
rendered dashboard. The dashboard now reads from localStorage
directly so it doesn't call this route, but anything else that
hits /api/dashboard/stats unauthenticated still got the lie.

Now: returns zeros on the unauthenticated path. No fake demo data.

## Trust impact

Closes the dashboard fabrication arc started in #164/#165/#166. Adds
the request-id contract to 5 more routes.

## Verified

- pnpm exec tsc --noEmit: clean
- pnpm check: 3 passed, 0 failed
- trust-gate: 16/44 route files (was 11/44)

## Rollback

Single git revert. 5 files.
operatoruplift added a commit that referenced this pull request Apr 27, 2026
#168)

Trust-gate coverage 16/44 -> 21/44, plus one more sci-fi cosplay
residual fixed.

## Routes adopting apiHelpers

| Route | Lines |
|---|---|
| app/api/gold/route.ts | 17 |
| app/api/risk/route.ts | 19 |
| app/api/auth/login/route.ts | 30 |
| app/api/auth/signup/route.ts | 36 |
| app/api/sns/resolve/route.ts | 35 |

Each adopts `withRequestMeta` for the X-Request-Id header. The two
auth routes plus risk also pick up `validationError()` for clean 400
responses with `{ missing: [...] }` details. Gold + risk pick up
`errorResponse()` for the 500 path.

## Drop "Commander" default name

`app/api/auth/signup/route.ts` was setting

  data: { display_name: name || 'Commander' }

PR #163 already removed "Commander" from the dashboard h1 ("Good
{greeting}, Commander."), and #166 cleaned up the rest of the
sci-fi cosplay vocabulary. Signup was the last surface where a fresh
user got "Commander" as their default display name.

Now: derives a default from the email's local part (jane.doe@x.com
-> "jane.doe"), falling back to "Friend" if email is missing.

## Verified

- pnpm exec tsc --noEmit: clean
- pnpm check: 3 passed, 0 failed
- trust-gate: 21/44 route files (was 16/44)

## Rollback

Single git revert. 5 files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant