Skip to content

fix(ui): remove PSP purple accent leaks#91

Merged
papi-ux merged 1 commit into
masterfrom
nova/theme-psp-remove-purple-leaks
Jun 25, 2026
Merged

fix(ui): remove PSP purple accent leaks#91
papi-ux merged 1 commit into
masterfrom
nova/theme-psp-remove-purple-leaks

Conversation

@papi-ux

@papi-ux papi-ux commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • Routes legacy XML drawable/layout accent colors through the active theme instead of hardcoded Polaris violet
  • Tints refresh spinners, snackbars, notifications, chips, focus rings, banners, and the Nova star through PSP steel-blue accents
  • Removes ProgressBar XML theme-attr tints that crash inflate and applies the empty-state spinner tint at runtime

Test Plan

  • RED: NovaFocusDrawableTest failed while focus/chip/server-row drawables still used @color/nova_accent
  • ./gradlew testDebugUnitTest --tests com.papi.nova.ui.NovaFocusDrawableTest --tests com.papi.nova.grid.KotlinGridAdaptersMigrationTest
  • ./gradlew testDebugUnitTest assembleRootDebug lintRootDebug
  • grep scan over drawable/color/layout/layout-land/java shows remaining default violet hits only in NovaThemeManager/Compose default Polaris fallback paths
  • adb install -r -d -g app/build/outputs/apk/root/debug/app-root-arm64-v8a-debug.apk on Retroid Pocket 6
  • forced com.papi.nova.root.debug prefs to nova_theme=portable_chrome
  • launched Nova Debug (Root) and verified package version/update time/activity via adb

@papi-ux papi-ux merged commit 53b93b2 into master Jun 25, 2026
6 checks passed
@papi-ux papi-ux deleted the nova/theme-psp-remove-purple-leaks branch June 25, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant