Skip to content

fix(ui): remove PSP purple accent leaks #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
papi-ux merged 1 commit into from
Jun 25, 2026
Merged

fix(ui): remove PSP purple accent leaks #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased

- Removes hardcoded Polaris-purple accents from legacy Nova XML/views so PSP / Portable Chrome uses theme-aware steel highlights.
- Deepens the PSP / Portable Chrome theme into a sleeker smoked-graphite handheld shell with less washed-out white.
- Adds a PSP / Portable Chrome Nova theme matching the Polaris dim Moonlight-grey early-2000s silver palette, including settings/theme-picker entries and restrained Compose library surfaces.

Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/papi/nova/AppView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ class AppView : AppCompatActivity(), AdapterFragmentCallbacks {
if (UiHelper.isTvDevice(this)) {
swipeRefresh.isEnabled = false
}
swipeRefresh.setColorSchemeColors(ContextCompat.getColor(this, R.color.nova_accent))
swipeRefresh.setColorSchemeColors(NovaThemeManager.getAccentColor(this))
swipeRefresh.setProgressBackgroundColorSchemeColor(
ContextCompat.getColor(this, R.color.nova_bg_elevated),
)
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/java/com/papi/nova/PcView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ class PcView : AppCompatActivity(), AdapterFragmentCallbacks {
spaceParticleView = findViewById(R.id.space_particles)
val swipeRefresh = findViewById<SwipeRefreshLayout>(R.id.swipe_refresh)
if (swipeRefresh != null) {
swipeRefresh.setColorSchemeColors(ContextCompat.getColor(this, R.color.nova_accent))
swipeRefresh.setColorSchemeColors(NovaThemeManager.getAccentColor(this))
swipeRefresh.setProgressBackgroundColorSchemeColor(
ContextCompat.getColor(this, R.color.nova_bg_elevated),
)
Expand Down Expand Up @@ -433,6 +433,8 @@ class PcView : AppCompatActivity(), AdapterFragmentCallbacks {
swipeRefresh.setColorSchemeColors(accent)
swipeRefresh.setProgressBackgroundColorSchemeColor(surface)
}
findViewById<android.widget.ProgressBar>(R.id.pcs_loading)?.indeterminateTintList =
ColorStateList.valueOf(accent)

findViewById<TextView>(R.id.pcViewTitle)?.setTextColor(textPrimary)
findViewById<TextView>(R.id.pcViewSectionLabel)?.setTextColor(textMuted)
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/com/papi/nova/service/NovaStreamNotification.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import android.content.Context
import android.os.Build
import androidx.core.app.NotificationCompat
import com.papi.nova.R
import com.papi.nova.ui.NovaThemeManager

/**
* Manages the persistent streaming notification.
Expand Down Expand Up @@ -52,7 +53,7 @@ object NovaStreamNotification {
.setPriority(NotificationCompat.PRIORITY_LOW)
.setContentIntent(returnPending)
.addAction(0, "Disconnect", disconnectPending)
.setColor(context.getColor(R.color.nova_accent))
.setColor(NovaThemeManager.getAccentColor(context))
.build()

val mgr = context.getSystemService(NotificationManager::class.java)
Expand Down
6 changes: 3 additions & 3 deletions app/src/main/java/com/papi/nova/ui/NovaSnackbar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ object NovaSnackbar {
val snackbar = Snackbar.make(rootView, message, duration)
snackbar.setBackgroundTint(activity.getColor(R.color.nova_bg_elevated))
snackbar.setTextColor(activity.getColor(R.color.nova_text_primary))
snackbar.setActionTextColor(activity.getColor(R.color.nova_accent))
snackbar.setActionTextColor(NovaThemeManager.getAccentColor(activity))
snackbar.show()
}

Expand All @@ -26,7 +26,7 @@ object NovaSnackbar {
val snackbar = Snackbar.make(rootView, message, Snackbar.LENGTH_LONG)
snackbar.setBackgroundTint(activity.getColor(R.color.nova_bg_elevated))
snackbar.setTextColor(activity.getColor(R.color.nova_error))
snackbar.setActionTextColor(activity.getColor(R.color.nova_accent))
snackbar.setActionTextColor(NovaThemeManager.getAccentColor(activity))
snackbar.show()
}

Expand All @@ -35,7 +35,7 @@ object NovaSnackbar {
val snackbar = Snackbar.make(rootView, message, Snackbar.LENGTH_SHORT)
snackbar.setBackgroundTint(activity.getColor(R.color.nova_bg_elevated))
snackbar.setTextColor(activity.getColor(R.color.nova_success))
snackbar.setActionTextColor(activity.getColor(R.color.nova_accent))
snackbar.setActionTextColor(NovaThemeManager.getAccentColor(activity))
snackbar.show()
}
}
2 changes: 1 addition & 1 deletion app/src/main/res/color/nova_chip_bg_selector.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:android="http://schemas.android.com/apk/res/android">
<item android:color="@color/nova_accent" android:state_checked="true" />
<item android:color="?attr/colorAccent" android:state_checked="true" />
<item android:color="#33687b81" /> <!-- match nova_badge_bg solid color -->
</selector>
2 changes: 1 addition & 1 deletion app/src/main/res/color/nova_focus_stroke_selector.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:android="http://schemas.android.com/apk/res/android">
<item android:color="@color/nova_ice" android:state_focused="true" />
<item android:color="@color/nova_accent" android:state_pressed="true" />
<item android:color="?attr/colorAccent" android:state_pressed="true" />
<item android:color="@android:color/transparent" />
</selector>
2 changes: 1 addition & 1 deletion app/src/main/res/drawable/ic_nova_star_foreground.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<!-- Inner accent — small 4-pointed sparkle -->
<path
android:fillColor="#FF7c73ff"
android:fillColor="?attr/colorAccent"
android:pathData="M54,42 Q55.5,52.5 64,54 Q55.5,55.5 54,66 Q52.5,55.5 44,54 Q52.5,52.5 54,42 Z" />

<!-- Center dot -->
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/drawable/nova_atv_banner.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
android:pathData="M60,10 Q63,52 100,60 Q63,68 60,110 Q57,68 20,60 Q57,52 60,10 Z" />
<!-- Inner accent -->
<path
android:fillColor="#7c73ff"
android:fillColor="?attr/colorAccent"
android:pathData="M60,40 Q62,57 75,60 Q62,63 60,80 Q58,63 45,60 Q58,57 60,40 Z" />
<!-- Center dot -->
<path
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/drawable/nova_card_bg_focusable.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<solid android:color="#3Ac8d6e5" />
<stroke
android:width="2dp"
android:color="@color/nova_accent" />
android:color="?attr/colorAccent" />
<corners android:radius="16dp" />
</shape>
</item>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/drawable/nova_card_focus_ring.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
<solid android:color="@android:color/transparent" />
<stroke
android:width="3dp"
android:color="@color/nova_accent" />
android:color="?attr/colorAccent" />
<corners android:radius="18dp" />
</shape>
6 changes: 3 additions & 3 deletions app/src/main/res/drawable/nova_chip_default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@
<solid android:color="@color/nova_badge_bg" />
<stroke
android:width="3dp"
android:color="@color/nova_accent" />
android:color="?attr/colorAccent" />
<corners android:radius="12dp" />
</shape>
</item>
<item android:state_selected="true">
<shape android:shape="rectangle">
<solid android:color="@color/nova_accent_surface" />
<solid android:color="?attr/colorControlHighlight" />
<stroke
android:width="2dp"
android:color="@color/nova_accent" />
android:color="?attr/colorAccent" />
<corners android:radius="12dp" />
</shape>
</item>
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/drawable/nova_chip_selected.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<selector xmlns:android="http://schemas.android.com/apk/res/android">
<item android:state_focused="true">
<shape android:shape="rectangle">
<solid android:color="@color/nova_accent" />
<solid android:color="?attr/colorAccent" />
<stroke
android:width="3dp"
android:color="@color/nova_ice" />
Expand All @@ -11,7 +11,7 @@
</item>
<item>
<shape android:shape="rectangle">
<solid android:color="@color/nova_accent" />
<solid android:color="?attr/colorAccent" />
<corners android:radius="12dp" />
</shape>
</item>
Expand Down
14 changes: 7 additions & 7 deletions app/src/main/res/drawable/nova_dialog_choice_bg.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,28 +3,28 @@
<item android:state_pressed="true">
<shape android:shape="rectangle">
<corners android:radius="4dp" />
<solid android:color="#407C73FF" />
<stroke android:width="2dp" android:color="@color/nova_accent" />
<solid android:color="?attr/colorControlHighlight" />
<stroke android:width="2dp" android:color="?attr/colorAccent" />
</shape>
</item>
<item android:state_selected="true">
<shape android:shape="rectangle">
<corners android:radius="4dp" />
<solid android:color="#337C73FF" />
<stroke android:width="2dp" android:color="@color/nova_accent" />
<solid android:color="?attr/colorControlHighlight" />
<stroke android:width="2dp" android:color="?attr/colorAccent" />
</shape>
</item>
<item android:state_focused="true">
<shape android:shape="rectangle">
<corners android:radius="4dp" />
<solid android:color="#337C73FF" />
<stroke android:width="2dp" android:color="@color/nova_accent" />
<solid android:color="?attr/colorControlHighlight" />
<stroke android:width="2dp" android:color="?attr/colorAccent" />
</shape>
</item>
<item android:state_activated="true">
<shape android:shape="rectangle">
<corners android:radius="4dp" />
<solid android:color="#247C73FF" />
<solid android:color="?attr/colorControlHighlight" />
</shape>
</item>
<item android:drawable="@android:color/transparent" />
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/drawable/nova_featured_action_bg.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<shape xmlns:android="http://schemas.android.com/apk/res/android"
android:shape="rectangle">
<solid android:color="@color/nova_accent_surface" />
<solid android:color="?attr/colorControlHighlight" />
<corners android:radius="14dp" />
<stroke
android:width="1dp"
android:color="@color/nova_accent_glow" />
android:color="?attr/colorControlHighlight" />
</shape>
2 changes: 1 addition & 1 deletion app/src/main/res/drawable/nova_ripple_accent.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Branded ripple using Nova accent color instead of default gray -->
<ripple xmlns:android="http://schemas.android.com/apk/res/android"
android:color="@color/nova_ripple">
android:color="?attr/colorControlHighlight">
<item android:id="@android:id/mask">
<shape android:shape="rectangle">
<solid android:color="@android:color/white" />
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/drawable/nova_server_row_focus_ring.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
<solid android:color="@color/nova_bg_elevated" />
<stroke
android:width="2dp"
android:color="@color/nova_accent" />
android:color="?attr/colorAccent" />
<corners android:radius="18dp" />
</shape>
4 changes: 2 additions & 2 deletions app/src/main/res/drawable/nova_tv_banner.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
android:fillColor="@android:color/transparent"
android:pathData="M54,138 C96,116 128,106 160,104 C192,102 224,92 266,70"
android:strokeAlpha="0.3"
android:strokeColor="#7c73ff"
android:strokeColor="?attr/colorAccent"
android:strokeLineCap="round"
android:strokeWidth="2" />

Expand All @@ -31,7 +31,7 @@
android:fillColor="#d4dde8"
android:pathData="M60,10 Q63,52 100,60 Q63,68 60,110 Q57,68 20,60 Q57,52 60,10 Z" />
<path
android:fillColor="#7c73ff"
android:fillColor="?attr/colorAccent"
android:pathData="M60,40 Q62,57 75,60 Q62,63 60,80 Q58,63 45,60 Q58,57 60,40 Z" />
<path
android:fillColor="#d4dde8"
Expand Down
8 changes: 4 additions & 4 deletions app/src/main/res/layout-land/activity_nova_welcome.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
android:letterSpacing="0.08"
android:text="01 Find your host"
android:textAllCaps="true"
android:textColor="@color/nova_accent"
android:textColor="?attr/colorAccent"
android:textSize="10sp" />

<TextView
Expand All @@ -102,7 +102,7 @@
android:letterSpacing="0.08"
android:text="02 Pair with confidence"
android:textAllCaps="true"
android:textColor="@color/nova_accent"
android:textColor="?attr/colorAccent"
android:textSize="10sp" />

<TextView
Expand All @@ -128,7 +128,7 @@
android:letterSpacing="0.08"
android:text="03 Built for handhelds and TV"
android:textAllCaps="true"
android:textColor="@color/nova_accent"
android:textColor="?attr/colorAccent"
android:textSize="10sp" />

<TextView
Expand Down Expand Up @@ -158,7 +158,7 @@
android:textColor="@android:color/white"
android:textSize="15sp"
android:textStyle="bold"
app:backgroundTint="@color/nova_accent"
app:backgroundTint="?attr/colorAccent"
app:cornerRadius="25dp"
app:strokeColor="@color/nova_focus_stroke_selector"
app:strokeWidth="2dp" />
Expand Down
9 changes: 4 additions & 5 deletions app/src/main/res/layout-land/activity_pc_view.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
app:cardBackgroundColor="@color/nova_bg_elevated"
app:cardCornerRadius="18dp"
app:cardElevation="0dp"
app:strokeColor="@color/nova_accent"
app:strokeColor="?attr/colorAccent"
app:strokeWidth="1dp">

<LinearLayout
Expand All @@ -163,7 +163,7 @@
android:letterSpacing="0.04"
android:text="@string/pcview_destination_current"
android:textAllCaps="true"
android:textColor="@color/nova_accent"
android:textColor="?attr/colorAccent"
android:textSize="10sp" />

<TextView
Expand Down Expand Up @@ -298,7 +298,7 @@
android:layout_weight="1"
android:text="@string/pcview_quick_add_server"
android:textAllCaps="false"
app:backgroundTint="@color/nova_accent_surface"
app:backgroundTint="?attr/colorControlHighlight"
app:cornerRadius="14dp"
app:elevation="0dp"
app:icon="@drawable/ic_add"
Expand Down Expand Up @@ -461,8 +461,7 @@
android:layout_width="32dp"
android:layout_height="32dp"
android:layout_marginTop="20dp"
android:indeterminate="true"
android:indeterminateTint="@color/nova_accent" />
android:indeterminate="true" />

<TextView
android:id="@+id/pcViewEmptyTitle"
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/layout/activity_app_view.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
android:layout_height="wrap_content"
android:text="@string/applist_hero_continue"
android:textSize="10sp"
android:textColor="@color/nova_accent"
android:textColor="?attr/colorAccent"
android:fontFamily="sans-serif-medium"
android:letterSpacing="0.1" />

Expand Down Expand Up @@ -273,7 +273,7 @@
android:layout_marginEnd="24dp"
android:contentDescription="@string/profile_manager_choose_profile"
app:icon="@drawable/ic_profiles"
app:backgroundTint="@color/nova_accent"
app:backgroundTint="?attr/colorAccent"
app:iconTint="@color/nova_ice" />

</FrameLayout>
8 changes: 4 additions & 4 deletions app/src/main/res/layout/activity_nova_welcome.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
android:letterSpacing="0.08"
android:text="01 Find your host"
android:textAllCaps="true"
android:textColor="@color/nova_accent"
android:textColor="?attr/colorAccent"
android:textSize="11sp" />

<TextView
Expand All @@ -93,7 +93,7 @@
android:letterSpacing="0.08"
android:text="02 Pair with confidence"
android:textAllCaps="true"
android:textColor="@color/nova_accent"
android:textColor="?attr/colorAccent"
android:textSize="11sp" />

<TextView
Expand All @@ -119,7 +119,7 @@
android:letterSpacing="0.08"
android:text="03 Built for the screen in your hands"
android:textAllCaps="true"
android:textColor="@color/nova_accent"
android:textColor="?attr/colorAccent"
android:textSize="11sp" />

<TextView
Expand All @@ -142,7 +142,7 @@
android:textColor="@android:color/white"
android:textSize="17sp"
android:textStyle="bold"
app:backgroundTint="@color/nova_accent"
app:backgroundTint="?attr/colorAccent"
app:cornerRadius="26dp"
app:strokeColor="@color/nova_focus_stroke_selector"
app:strokeWidth="2dp" />
Expand Down
Loading
Loading