Rewrite from ReasonML to TypeScript#45
Conversation
These changes are inspired by the fact that ReasonML was a very interesting learning experience years back and was a cool challenge, but as time as passed, the ReasonML aspect of this tool has severily held back external contributions. Since the initial creator has stopped using GitLab the recent years, it's even more important for this project to be approachable by new collaborators, where TypeScript certainly opens up the possibilities a lot more. Lots of help from our new AI companions, the .ts files are meant to be a direct translation of the old .re variants. Few nitpicky changes has been done after initial AI translation, let's see if it works in practice or not.
Out with ReasonML build tools, in with corresponding TypeScript tools.
As discovered when publishing a new beta version: ``` npm WARN publish npm auto-corrected some errors in your package.json when publishing. Please run "npm pkg fix" to address these errors. npm WARN publish errors corrected: npm WARN publish "bin" was converted to an object npm WARN publish "repository" was changed from a string to an object npm WARN publish "repository.url" was normalized to "git+https://github.com/phillipj/gitlab-search.git" ``` Changes were made by `npm pkg fix`.
|
I have tested the script. The setup phase seems to be working correctly. The search seems not to be working. There are no errors, but I don't get any results when I try to search for something. I have tried the same query with the latest release of the ReasonML version; in this case, it works correctly. TypeScript output: |
|
@marsluca much appreciated! I've had trouble testing due to gitlab.com not allowing me to use the Search API. Since you dont get any obvious errors, I'd be curious to know if you have a specific subscription on gitlab.com, or use an on-premise instance? If on-premise, what version are you on? Sorry for the stupid questions, I'm just looking for hints to know how I can test this myself as well (since I'm no longer an active Gitlab user these days). |
|
Thanks, @phillipj , for your quick reply. I have tested the script using GitLab Enterprise Edition v17.8.5-ee, which is hosted and managed by the company where I work. I don't know if, with the self-managed GitLab Community Edition, you can overcome your testing limitation: https://hub.docker.com/r/gitlab/gitlab-ce/ |
|
GitLab Enterprise Edition v16.11.9-ee, self hosted, and node:16.14.2 i installed I often have this crash also (same search): or sometimes this : if I search with debug activated, I don't have errors anymore, but still the same first letter search Now, the fun part: the version 1.5.0 also give me often these errors. I mean, more than 50% of the time. I just have to retry until I have my result. So, the same search with 1.5.0 when crashing : a few retries later (without changing anything), I have my correct results with 1.5.0, not just the first letter. |
3 participants
These changes are inspired by the fact that ReasonML was a very interesting learning experience years back and was a cool challenge, but as time as passed, the ReasonML aspect of this tool has severely held back external contributions.
Since the initial creator has stopped using GitLab the recent years, it's even more important for this project to be approachable by new collaborators, where TypeScript certainly opens up the possibilities a lot more.
Lots of help from our new AI companions, the .ts files are meant to be a direct translation of the old .re variants. Few nitpicky changes has been done after initial AI translation, let's see if it works in practice or not.
Help needed
My free free GitLab version prevents me from testing this; I got 403 responses from GitLab as the "blobs search" is not available under the free plan anymore.
❓ anyone have either an on-premise or paid plan and can help with happy path testing?
Closes #43